Skip to content

Conversation

@mochetts
Copy link

@mochetts mochetts commented Oct 3, 2025

The matcher that checks that a job has been enqueued on a specific queue isn't working properly with symbols.

So if I do:

expect(Sidekiq::Consumer::GiftDeliveryJob).to have_enqueued_sidekiq_job.on(:scheduled_gifts)

...It fails, but if I do

expect(Sidekiq::Consumer::GiftDeliveryJob).to have_enqueued_sidekiq_job.on("scheduled_gifts")

... It passes.

Given that the queue in sidekiq can be set both with symbols and strings, the expectation should handle this gracefully.

Before I add tests, I'd like to get thoughts on this.

Thanks.

@ydah
Copy link
Collaborator

ydah commented Oct 14, 2025

Thank you for sending the pull request. I think it makes sense. Can you send a complete pull request with test code?

@mochetts
Copy link
Author

Sure thing. I'll add them tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants