Conversation
Frotty
force-pushed
the
master
branch
2 times, most recently
from
3bbfe78 to
fdcd03d
Compare
Donach
added a commit
to Code-Fixxers/WurstScript
that referenced
this pull request
Apr 1, 2026
1. FunctionSignature.matchAgainstArgs: Remove duplicate matchAgainstSupertype call that was added for debug logging but passed potentially-null mapping to the second call, causing NPE on generic static method calls. 2. FuncLink.create: Only add function's own type parameters as type variables in the mapping. Enclosing structure type params (class/module) are resolved through receiver type matching, not through argument inference. 3. FunctionSignature.fromNameLink: Only add function definition's own type parameters as type variables, not enclosing structure params. This prevents module type params from appearing as unbound inference variables. 4. FuncLink.withTypeArgBinding: Also check if any type params are being bound (even when types don't change structurally, e.g., T bound to itself within a generic module) to ensure the FuncLink is updated. 5. WurstValidator: Downgrade variable-hides-superclass-variable from error to warning, matching pre-wurstscript#1098 behavior. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Donach
added a commit
to Code-Fixxers/WurstScript
that referenced
this pull request
Apr 3, 2026
1. FunctionSignature.matchAgainstArgs: Remove duplicate matchAgainstSupertype call that was added for debug logging but passed potentially-null mapping to the second call, causing NPE on generic static method calls. 2. FuncLink.create: Only add function's own type parameters as type variables in the mapping. Enclosing structure type params (class/module) are resolved through receiver type matching, not through argument inference. 3. FunctionSignature.fromNameLink: Only add function definition's own type parameters as type variables, not enclosing structure params. This prevents module type params from appearing as unbound inference variables. 4. FuncLink.withTypeArgBinding: Also check if any type params are being bound (even when types don't change structurally, e.g., T bound to itself within a generic module) to ensure the FuncLink is updated. 5. WurstValidator: Downgrade variable-hides-superclass-variable from error to warning, matching pre-wurstscript#1098 behavior. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.