Skip to content

Fix cache manifest not saving: open MPQ writable in ProjectConfigBuilder #1176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Frotty merged 1 commit into from
Apr 1, 2026
Merged

Fix cache manifest not saving: open MPQ writable in ProjectConfigBuilder #1176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions de.peeeq.wurstscript/src/main/java/de/peeeq/wurstio/languageserver/ProjectConfigBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,8 @@ public static MapRequest.CompilationResult apply(WurstProjectConfigData projectC
// Apply map header (this is cheap, so we always do it)
applyMapHeader(projectConfig, targetMap);

// Update the manifest with new config hash
try (MpqEditor mpq = MpqEditorFactory.getEditor(Optional.of(targetMap), true)) {
// Update the manifest with new config hash (must open writable to insert)
try (MpqEditor mpq = MpqEditorFactory.getEditor(Optional.of(targetMap), false)) {
ImportFile.CacheManifest manifest = ImportFile.getCachedManifest(mpq).orElse(new ImportFile.CacheManifest());
manifest.setMapConfig(configHash);
ImportFile.saveManifest(mpq, manifest);
Expand Down
Loading