This repository was archived by the owner on May 5, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 73
Master based xamarin auth as nuget component #43
Open
moljac
wants to merge
20
commits into
xamarin:master
Choose a base branch
from
moljac:master-based-xamarin-auth-as-nuget-component
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Master based xamarin auth as nuget component #43
moljac
wants to merge
20
commits into
xamarin:master
from
moljac:master-based-xamarin-auth-as-nuget-component
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xamarin.Auth fixes for Xamarin.Social project with references to nugets and projects
MacOSX solution for cake added
nuspec modified source referencing Xamarin.Auth nuget added
…t reference projects
| @@ -1,3 +1,3 @@ | |||
| [submodule "Xamarin.Auth"] | |||
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to keep this as a submodule, or should it just be moved to a NuGet dependency?
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explanation:
- Xamarin.Auth was used as submodule in earlier version (on master branch), so I just moved it to external/ folder to match our CI system
- during development it helps to reference projects for easier debugging and fixing
- there are still features to be added (Windows platforms) to Xamarin.Social, so it would be beneficial to keep Xamarin.Auth as a submodule for a while
…onditional project referencing)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xamarin.Auth dependency as nuget
Xamarin.Social nuget packaging
CI structure