(fix) circular import issue #1264 #1280
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1280 +/- ##
====================================
Coverage 95% 95%
====================================
Files 66 66
Lines 2753 2753
====================================
Hits 2609 2609
Misses 144 144 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
You are a legend! Thank you @abaart . Now I see why it was causing the circular dependency, we cannot reference cx_core directly from any module inside cx_core. We have to import directly from the file. Lesson learnt. I will merge and remove the cx_core exclusion from the documentation as well as add the note in the release note and give you the credit. Thanks! |
xaviml
added a commit
that referenced
this pull request
Jan 3, 2026
Owner
|
This is now released in ControllerX v5.2.2. |
|
However, it doesn't work with appdaemon 0.17.13, which I just updated, so I restored 0.17.10 again... |
Owner
|
Hi @mycanaletto , It is working on my side with AppDaemon 0.17.13. Could you show me the complete logs of AppDaemon (from start to error) when upgrading to 0.17.13? Cheers, |
|
@xaviml thanks |
|
Owner
|
Hi @mycanaletto , Are this all logs you see? I don't see the ControllerX initialization logs and the error you get. Could you please share all logs (from the beginning to the error (included) with AppDaemon 0.17.13? Cheers, |
|
That's what I did, but when I update to 0.17.13, ControllerX won't even launch... Here is the log with the rollback to 0.17.10. |
Owner
|
Hi @mycanaletto , I understand, so you are not getting the circular dependency error (which is what this PR solves). You simply don't see anything happening when initializing AppDaemon addon on the new version. Is that correct? Could you do the following for me?
Cheers, |
|
voilà !
|
Owner
|
Everything looks correct from confogurstion point of view. What I see is that this is not a ControllerX issue, but an AppDaemon one. If you run 0.17.13, does it get stuck and nothing loads? I see in your first logs you shared that 0.17.13 started, but then it stopped and then I see logs of 0.17.10. Don't you see anything with 0.17.13? Not even other AppDaemon apps? Cheers, |
|
Yes, the problem is appDaemon 0.17.13 (.11 and .12 are the same). I tried deleting Automoli and leaving just one ControllerX app, but the result was the same... |
Owner
|
What about if you remove all apps? And leave the hellow world one? hello_world_app: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1264
I was running into this problem, AppDaemon was using 100% CPU due to continuously trying to load controllerx, but failing due to the circular import.
I with this fix applied, I now run controllerx without issues, without:
in
/addon_configs/a0d7b954_appdaemon/appdaemon.yamlI suggest that if others also verify this fixes the problem, the mention of
exclude_dirscan be removed from the documentation.Other relevant issue: hassio-addons/addon-appdaemon#433