Repository navigation
👷 ci(code-review): call the workflow from xdanger/xdanger - #4
Merged
Merged
Conversation
- 👷 the shared review workflow moved from `krosdai/.github` to `xdanger/xdanger`; keep the same tag so the review behaviour stays unchanged Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟢 Approval recommended
The destination workflow exists at @v1 and its inputs, secret declaration, and permissions are compatible with the caller.
No open issues 🎉
What changed in this PR
Updates the code-review workflow caller to the shared workflow’s new personal-account location.
Changes:
- Switches from
krosdai/.githubtoxdanger/xdanger, retaining@v1and the existing inputs and secret mapping.
| File | Description |
|---|---|
.github/workflows/code-review.yml |
Points the reusable workflow call to its new repository. |
Review effort: Balanced
- 👷 `v1` needs an `ANTHROPIC_API_KEY` secret that only the old `krosdai` organization provided; `v2` authenticates through workload identity federation instead - 🔥 drop the `secrets:` block, since `v2` no longer declares `ANTHROPIC_API_KEY` and passing it fails workflow validation Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared code-review workflow moved from
krosdai/.githubtoxdanger/xdangerwhen the repositories moved to the personal account. This pointsuses:at the new location and moves the caller from@v1to@v2.v1needed anANTHROPIC_API_KEYsecret that only the oldkrosdaiorganization provided.v2authenticates through workload identity federation instead, so thesecrets:block is gone:v2no longer declares that secret, and passing it fails workflow validation. The workflow already grantsid-token: write, which the token exchange needs.The four
FEDERATION_*repository variables thatv2reads are now set on this repository, copied fromxdanger/xdanger, because a personal account has no account-level Actions variables.🤖 Generated with Claude Code