This consolidates the contents of #13, #14 and #17 into one PR#18
Open
This consolidates the contents of #13, #14 and #17 into one PR#18
Conversation
It should now be possible to inherit from `ApplyTargetConfig` and override the `_get_config` member function to return a new config.
xDSL now uses a different value for the dynamic index marker - `builtin.DYNAMIC_INDEX` with value `-(2**63)`, which matches the value MLIR uses for this. Now `memref`s, and `tensor`s that use `-1` as the dynamic index get printed with a literal `-1`, rather than `?`.
xDSL has dropped support for typed llvm pointers, so the default ctor now produces the equivalent of the old `LLVMPointerType.opaque()`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commits from those PRs were cherry-picked on top of
mainWarning
The changes in this PR work with xDSL
v0.54.4, last release before xdsl873c48a9afe2b0ce6e8413d29f8c1456288f3fc7, which moves to LLVM21.#13 Make
apply-targetextensible with new targetsIt should now be possible to inherit from ApplyTargetConfig and
override the _get_config member function to return a new config.
#14 Fix the else condition for sending implicitly mapped data
If the data is already present on the device, instead of sending it again, just return an element count of 2^64. When waiting for data, check if element count is 2^64 and if so, don't wait.
#17 Replaced uses of -1 as the dynamic index marker
xDSL now uses a different value for the dynamic index marker - builtin.DYNAMIC_INDEX with value -(2**63), which matches the value MLIR uses for this.
Now memrefs, and tensors that use -1 as the dynamic index get printed with a literal -1, rather than ?.
Closes #16
Additional changes
Replaced the use of
LLVMPointerType.opaque()withLLVMPointerType()as typed llvm pointers have been removed from xDSLSet xDSL version in
pyproject.tomlto latest supported.Correctness test results
Filecheck results