Fix wrong clientset used for target cluster in CompareCronJobs#36
Open
prjanitor wants to merge 1 commit intoxendit:mainfrom
Open
Fix wrong clientset used for target cluster in CompareCronJobs#36prjanitor wants to merge 1 commit intoxendit:mainfrom
prjanitor wants to merge 1 commit intoxendit:mainfrom
Conversation
The CompareCronJobs function was incorrectly using clientsetToSource for both source and target cluster queries. This caused the comparison to compare the source cluster against itself instead of comparing source vs target. Changed line 18 to use clientsetToTarget when querying the target cluster's cronjobs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Description
In
compare/cronjobs.go, theCompareCronJobsfunction incorrectly usesclientsetToSourcefor both source and target cluster queries. This means the comparison was comparing the source cluster against itself instead of comparing source vs target.Fix
Changed line 18 to use
clientsetToTargetwhen querying the target cluster's cronjobs:Verification
This pattern is consistent with other comparison functions in the codebase (e.g.,
CompareClusterRoleBindings,CompareClusterRoles) which correctly use separate clientsets for source and target queries.This PR was generated by PRJanitor — an automated tool that finds and fixes small bugs in open-source projects.
We respect your contribution guidelines — if your project doesn't accept bot PRs, we won't send more. You can also add a
.github/prjanitor.ymlfile withenabled: falseto opt out explicitly.