Fix Dired DWIM context fallback - #789
Open
rpoisel wants to merge 1 commit into
Open
Conversation
Dired's current-line fallback is useful for explicit file sending, but it should not count as automatic context when starting or reusing a shell. Only use region-selected or explicitly marked Dired files for automatic file context, and skip current-line context in Dired so raw listing rows are not inserted into prompts. Co-Authored-By: OpenAI Codex GPT-5 <noreply@openai.com> Signed-off-by: Rainer Poisel <rainer@embedded-focus.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dired's current-line fallback is useful for explicit file sending, but it should not count as obvious context when starting or reusing a shell.
Only use region-selected or explicitly marked Dired files for automatic file context, and skip current-line context in Dired so raw listing rows are not inserted into prompts.
Note: I am not really good at writing elisp code. This commit has been created with the assistance of an AI agent (OpenAI Codex). I do understand the code, but there might be better ways to improve the situation. It works for me - I am typically starting agent-shell sessions from dired buffers without selecting entries (files, directories, etc.).
Checklist
a new featurethe observed behavior: Dired DWIM context can insert prompt garbage into new agent sessions #788M-x checkdocandM-x byte-compile-file.