Skip to content

Stop failing the run and let the user decide how to proceed#136

Open
xt0rted wants to merge 3 commits into
mainfrom
stop-failing-the-run
Open

Stop failing the run and let the user decide how to proceed#136
xt0rted wants to merge 3 commits into
mainfrom
stop-failing-the-run

Conversation

@xt0rted

@xt0rted xt0rted commented Feb 23, 2020

Copy link
Copy Markdown
Owner

This was brought up in #124. The only time we should fail the run is when the user lacks the required permissions to trigger this step so this removes the calls to setFailed() and replaces them with debug().

To tell if this step was a success or not you can check the out params like so:

- run: echo "Runs only on /lint js command"
  if: steps.command.outputs.command-name && steps.command.outputs.command-arguments == 'js'

A subsequent PR will add a new has-command out parameter that's meant for these types of checks.

This is a breaking change for v1 so it'll be released as v2.

@xt0rted xt0rted added the enhancement New feature or request label Feb 23, 2020
@codecov

codecov Bot commented Feb 23, 2020

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.74%. Comparing base (3a57d7f) to head (c20683a).
⚠️ Report is 1319 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #136   +/-   ##
=======================================
  Coverage   86.74%   86.74%           
=======================================
  Files           5        5           
  Lines          83       83           
  Branches       11       11           
=======================================
  Hits           72       72           
  Partials       11       11           
Flag Coverage Δ
unittests 86.74% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dav009

dav009 commented Mar 16, 2020

Copy link
Copy Markdown

is this getting merged soon ?

Base automatically changed from master to main March 21, 2021 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants