Repository navigation
Skip doc attributes that are not doc comments - #69
Merged
Merged
Conversation
A #[doc(alias = "...")] next to a doc comment made the derive panic with "not implemented", because every doc attribute was expected to be #[doc = "..."]. Fixes #68.
Manishearth
approved these changes
Oct 20, 2026
Collaborator
|
CI failures need #70 |
Manishearth
approved these changes
Oct 21, 2026
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #68
Displayderive collected every#[doc ...]attribute and expected each one to be#[doc = "..."]. Anything else hit_ => unimplemented!(), so a#[doc(alias = "Baz")](or#[doc(hidden)],#[doc(cfg(...))]) next to a doc comment made the derive panic withnot implemented, as in the issue.The doc attributes now go through
filter_map, which keeps the string literals and skips the other forms. The text still comes only from the doc comments, so the variant in the issue displays asStation Mode.tests/happy.rsgets the enum from the issue (/// Station Mode+#[doc(alias = "Baz")]) and checksDocAlias::Bardisplays asStation Mode. Onmasterthat test file doesn't compile (proc-macro derive panicked,message: not implemented).cargo testpasses on Rust 1.99.1,cargo fmt --checkis clean, and there's a line under Unreleased > Changed in the changelog.Note: I used Claude Code while working on this.