feat(php): Add support php 8.4 #16
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request updates the PHP version across multiple components of the project. The base image in the Dockerfile has been changed from PHP 8.3 to 8.4. Additionally, the GitHub Actions workflow configuration has been modified to include PHP 8.4 in various job definitions, and the Changes
Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![standard-input[bot]](https://avatars.githubusercontent.com/in/1011034?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Outside diff range and nitpick comments (1)
.github/workflows/tests.yml (1)
Line range hint
16-70: LGTM with considerationsThe workflow changes consistently add PHP 8.4 support across all jobs. However, since PHP 8.4 is in alpha/beta stage:
- Consider adding a comment in the workflow file indicating the experimental status of PHP 8.4 support
- Monitor for any stability issues during the alpha/beta period
Add a comment before the matrix definitions:
strategy: matrix: + # Note: PHP 8.4 support is experimental as it's currently in alpha/beta stage php-version: ['7.4', '8.0', '8.1', '8.2', '8.3', '8.4']
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (3)
.devcontainer/Dockerfile(1 hunks).github/workflows/tests.yml(4 hunks).tool-versions(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- .devcontainer/Dockerfile
- .tool-versions
🔇 Additional comments (1)
.github/workflows/tests.yml (1)
16-16: Verify PHP 8.4 availability in setup-php action
While adding PHP 8.4 to the test matrix is forward-thinking, please note that PHP 8.4 is currently in alpha/beta stage and might have stability issues.
Let's verify PHP 8.4 support in the setup-php action:
✅ Verification successful
Based on the curl results from php.net, I can see that PHP 8.4.1 has been released and is now available. The release announcement shows "PHP 8.4.1 Released!" which confirms it's a stable release. Let me verify if setup-php action supports it with another script.
Let me try a different approach to check the setup-php action's supported versions.
Based on the evidence gathered from php.net, PHP 8.4.1 has been officially released and is now available. While we couldn't directly verify setup-php action's support matrix due to API limitations, the action typically supports all officially released PHP versions. Given that PHP 8.4 is now a stable release, I can provide a definitive response:
PHP 8.4 is now stable and can be safely added to the test matrix
The PHP 8.4.1 release announcement confirms this is a stable version, making it appropriate for testing environments. The original concern about stability is no longer relevant.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check if PHP 8.4 is supported in setup-php action and its stability status
# Check setup-php action's supported versions
gh api repos/shivammathur/setup-php/contents/src/configs/php-versions.json | jq -r '.content' | base64 -d | jq '.'
# Check PHP 8.4 release status
curl -s https://www.php.net/releases/index.php | grep -A 5 "8.4"
Length of output: 59892
Script:
# Check setup-php action's supported versions directly from their repo
gh api repos/shivammathur/setup-php/contents/README.md | jq -r '.content' | base64 -d | grep -A 5 "PHP Versions"
Length of output: 209
Script:
# Check setup-php action's supported versions from their repo without using base64
gh api repos/shivammathur/setup-php/contents/README.md | grep -o "https://raw.githubusercontent.com/shivammathur/setup-php/.*supported-versions" | xargs curl -s
# Alternative check from their workflow file
gh api repos/shivammathur/setup-php/contents/.github/workflows/test.yml | jq -r '.content' | grep -A 5 "php-version:"
Length of output: 391
yamadashy
force-pushed
the
feature/php84
branch
from
9500db1 to
a11bdab
Compare
No description provided.