UI: Browser - Support views by mahesh-ynput · Pull Request #1970 · ynput/ayon-core

mahesh-ynput · 2026-07-24T04:40:16Z

Changelog Description

Fix all bugs in "views" functionality in redesigned-browser

Additional info

Local browser "views" functionality should match with web

Fix #1806

Testing notes:

Create different kind of views from products page and share it with multiple users with different permissions
Login different users from launcher and cross check complete "views" functionality should match with web
Sorting, hiding columns, order of columns should be same as we see in web view to local view with respective views

TODO:

mahesh-ynput · 2026-07-24T05:06:11Z

BigRoy · 2026-07-24T08:21:35Z

Fix Star Icon Working needs to remove from view, (@BigRoy any idea why this here?)

No idea - it should really behave like the web frontend. I don't see a reason for that 'star'.

Add Columns order should be with user view? @BigRoy

The columns + filter should be included in the view, the slicer I believe should not. The slicer mode should be included, but not the slicer selection. (So it should remember whether it's on "Hierarchy" or "Reviews")

Also, note that the top "Folders" and "Reviews" tabs are still there only for development purposes, so that you can compare easily with the old loader - upon release we will NOT have that separation (those tabs won't be there).

Columns being hidable and reorderable, please in separate PR

It's also important that the views logic is mostly a "state manager" and preferably this state that it manages is not hardcoded into the "Views" logic. Because we may get similar Views support in e.g. Launcher or other tools. As such, it'd be great to keep in mind that the views purely store a named state and manage that, but it's up to what this particular view manager is connected to it to adjust based on it so that it can be used in a variety of tools as the "view state manager" etc.

… hierarchy instance has only entity "versions" and review_sessions instance will have entity type per session so no where we needed to filter entityType - Disabled folderName filter for hierarchy instance those can be filtered directly from ReviewSlicer

- replaced the shared "versions" view type (a web UI identifier) - "desktop.browser" for browser table instance filters - "desktop.reviews" for review_sessions table filters - replace raw_post/raw_patch with ayon_api.post/ayon_api.patch - fixed save_view by "id" pop from POST payload (server rejected "" as an invalid entity ID)

- _review_table.py clearing applied filters on deletion of view - view_selector.py capturing current UI state into the view before editing so it can save the changes

… later help to highlight view button upon any modifications in view

…yle after init in buttons.py - Changing "view" menubutton color to blue same as web when any filter is modified in view_selector.py

…lick save silently save as in web

…e them further - improved filter capture method by using view bindings

…elpers - added _HoverReveal filter to match UX match with web.

mahesh-ynput · 2026-07-27T10:30:35Z

In the View lists:

The save button should appear on any row if you hover over it, but it should be there by default (even when not hovering) and highlighted on the row of your list active view from which you started making changes, e.g.

Enter view "X"

Make some edits

You're now in a working view, but on view "X" you see the highlighted save button.

However, if you hover another existing view you also get the save button so you can always save your working view into any existing views.

21dd7f3

mahesh-ynput · 2026-07-27T11:35:45Z

@BigRoy , Currently I see on clicking of "working view" reset in web it just looking for any default view we set at project or studio else clearing all filters. Can you please confirm the same logic we should apply here in local browser side too?

BigRoy · 2026-07-27T11:47:38Z

@BigRoy , Currently I see on clicking of "working view" reset in web it just looking for any default view we set at project or studio else clearing all filters. Can you please confirm the same logic we should apply here in local browser side too?

Yes - if we can support studio/project level defaults then that's the way it should work:

Reset to default means:

reset to project default if set
reset to studio default if set
reset to AYON default

- added default view section for studio and project default view

- removed legacy visibility fallback and enforce web format payload validation in desktop models/tests

mahesh-ynput · 2026-07-29T08:38:53Z

@BigRoy, UI part is ready, need few enhancements but I need right end points to sharing view with access, set studio/project defaults

iLLiCiTiT · 2026-08-27T09:19:16Z

+DEFAULT_SORT_BY = None
+DEFAULT_SORT_DESC = False
+DEFAULT_ROW_HEIGHT = 34
+DEFAULT_GROUPING = GroupingDef()
+DEFAULT_FILTER = FilterDef()
+DEFAULT_EXTRA = {
+    "gridHeight": 230,
+    "displayType": "table",
+    "featuredVersionOrder": ["latestDone", "latest", "hero"],
+}


Why these were added? Re-using the same object for default value is dangerous. Having these as constants doesn't make sense at all (at least I don't see any reason).

Only thing that needs custom defaults is extra, and that one should use function instead of stored value too.

def _get_default_extra() -> dict[str, Any]: return { "gridHeight": 230, "displayType": "table", "featuredVersionOrder": ["latestDone", "latest", "hero"], }

To be used as field(default_factory=_get_default_extra).

942e055, Can we do this way?

…ol.py and update ViewSettings

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

iLLiCiTiT · 2026-09-02T07:08:18Z

+            item = layout.takeAt(0)
+            widget = item.widget() if item is not None else None
+            if widget is not None:
+                widget.deleteLater()


Suggested change

widget.deleteLater()

widget.setVisible(False)

widget.deleteLater()

iLLiCiTiT · 2026-09-02T07:09:40Z

+        self.studio_default_view: View | None = None
+        self.project_default_view: View | None = None
+
+        self._studio_control: AYContainer | None = None


Why it is called control?

control(AYContainer) which using to set and unset project and studio defaults when we set any defaults it modify the widgets inside

iLLiCiTiT · 2026-09-02T07:14:07Z

+            )
+            return
+        try:
+            self._selector._apply_view(self.studio_default_view, emit=True)


This probably should be public method.

There are many private methods from self._selector are in private methods. I'm bit unclear which and all needs to make public.

iLLiCiTiT · 2026-09-02T07:15:20Z

+        self._selector._bindings.apply(default_view)
+        self._selector._clear_modified()
+        self._selector._close_menu()


Eh? This should be one public method on selector.

iLLiCiTiT · 2026-09-02T07:17:18Z

-        self._id_to_type: dict[str, str] = {}
+        # view_id -> (view_type, scope) (survives list_views; used by
+        # delete_view so it doesn't require a populated per-type cache).
+        self._id_to_view_attributes: dict[str, tuple[str, Scope]] = {}


I would rename it to _view_attributes_by_id.

iLLiCiTiT · 2026-09-02T07:20:35Z

        self.views_changed.emit(saved.view_type)
        return saved

+    def patch_view_access(self, view_id: str, access_data: dict[str, Any], should_share_access) -> None:


Suggested change

def patch_view_access(self, view_id: str, access_data: dict[str, Any], should_share_access) -> None:

def patch_view_access(

self, view_id: str,

access_data: dict[str, Any],

should_share_access: bool,

) -> None:

iLLiCiTiT · 2026-09-02T07:21:27Z

+        if not powerpack_version:
+            self.error.emit("Could not resolve powerpack addon version")
+            return
+        visibility = Visibility.PUBLIC.value if should_share_access else Visibility.PRIVATE.value


Suggested change

visibility = Visibility.PUBLIC.value if should_share_access else Visibility.PRIVATE.value

visibility = (

Visibility.PUBLIC.value

if should_share_access

else Visibility.PRIVATE.value

)

iLLiCiTiT · 2026-09-02T07:22:20Z

+            if is_studio:
+                ayon_api.delete(f"views/{view_type}/{view_id}")
+            else:
+                ayon_api.delete(
+                    f"views/{view_type}/{view_id}",
+                    project_name=self._project_name,
+                )


Suggested change

if is_studio:

ayon_api.delete(f"views/{view_type}/{view_id}")

else:

ayon_api.delete(

f"views/{view_type}/{view_id}",

project_name=self._project_name,

)

body = {}

if not is_studio:

body = dict(project_name=self._project_name)

ayon_api.delete(f"views/{view_type}/{view_id}", **body)

iLLiCiTiT · 2026-09-02T07:34:22Z

+        self._owner_label.setText(owner_name)
+
+        # Recreate owner avatar with updated name
+        self._owner_avatar._name = owner_name
+        self._owner_avatar._full_name = owner_name


Shouldn't this be one public method?

iLLiCiTiT · 2026-09-02T07:35:20Z

+        """Populate access control rows from _access_dict."""
+        # Clear existing rows
+        for widget in self._access_row_widgets.values():
+            widget.deleteLater()


Suggested change

widget.deleteLater()

widget.setVisible(False)

widget.deleteLater()

iLLiCiTiT · 2026-09-02T07:41:37Z

+            layout_margin=0
+        )
+
+        not_modified = (


Could we swap the name to avoid not_* that is then checked as if not not_modified:...

Suggested change

not_modified = (

modified = not (

iLLiCiTiT · 2026-09-02T07:52:02Z

+            and not self._suppress_auto_apply
+        ):
+            self._apply_view(working, emit=True)
+            return


Suggested change

return

iLLiCiTiT · 2026-09-02T07:53:01Z

-            working = next((v for v in self._views if v.working), None)
-            if working is not None:
-                self._apply_view(working, emit=True)
+        working = self._ensure_working_view_exists()


Suggested change

working = self._ensure_working_view_exists()

working_view = self._ensure_working_view_exists()

iLLiCiTiT · 2026-09-02T07:58:04Z

+
+            # Find the full name from usernames_and_groups
+            user_full_name = user_name
+            for user in self.usernames_and_groups.get("users", []):


Suggested change

for user in self.usernames_and_groups.get("users", []):

for user in self.usernames_and_groups["users"]:

iLLiCiTiT · 2026-09-02T07:58:33Z

+            # Find the full name from usernames_and_groups
+            user_full_name = user_name
+            for user in self.usernames_and_groups.get("users", []):
+                if user.get("name") == user_name:


Suggested change

if user.get("name") == user_name:

if user["name"] == user_name:

iLLiCiTiT · 2026-09-02T08:01:42Z

    def _on_edit_clicked(self, view: View) -> None:
        """Open the editor for an existing view."""
        self._close_menu()
+        editable = View.from_payload(view.to_payload())


I guess the editable is a view to edit? I would call it view_copy.

iLLiCiTiT · 2026-09-02T08:03:06Z

+        users = []
+        groups = []
+        try:
+            users = ayon_api.get_users(project_name=project_name) or []


Suggested change

users = ayon_api.get_users(project_name=project_name) or []

users = ayon_api.get_users(project_name=project_name)

iLLiCiTiT · 2026-09-02T08:03:53Z

+            user_full_name = user_name
+            for user in self.usernames_and_groups.get("users", []):
+                if user.get("name") == user_name:
+                    user_full_name = user.get("fullName", "") or user_name


Suggested change

user_full_name = user.get("fullName", "") or user_name

user_full_name = user["fullName"] or user_name

iLLiCiTiT · 2026-09-02T08:10:44Z

        """Update state when the popup signals it has closed."""
        self._menu_open = False
+        if QtWidgets.QApplication.mouseButtons() & Qt.MouseButton.LeftButton:
+            local_pos = self.mapFromGlobal(QtGui.QCursor.pos())


Suggested change

local_pos = self.mapFromGlobal(QtGui.QCursor.pos())

local_pos = self.mapFromGlobal(QtGui.QCursor.pos())

if isinstance(local_pos, QtCore.QPointF):

local_poc = local_pos.toPoint()

iLLiCiTiT · 2026-09-02T08:11:56Z

+            item = self._list_layout.takeAt(0)
+            w = item.widget()
+            if w:
+                w.deleteLater()


Suggested change

w.deleteLater()

w.setVisible(False)

w.deleteLater()

iLLiCiTiT · 2026-09-02T08:12:49Z

+        Args:
+            text: Search string typed into the line edit.
+        """
+        needle = text.lower()


The needle you search for in a haystack :)

Ok... I see... Could it be text_filter instead?

BigRoy · 2026-09-11T21:19:21Z

Closing in favor of #2031

…ents there

mahesh-ynput self-assigned this Jul 24, 2026

mahesh-ynput requested a review from Copilot July 24, 2026 04:40

ynbot added the size/XXL label Jul 24, 2026

mahesh-ynput requested a review from BigRoy July 24, 2026 04:40

Copilot started reviewing on behalf of mahesh-ynput July 24, 2026 04:40 View session

mahesh-ynput removed the request for review from Copilot July 24, 2026 04:40

mahesh-ynput mentioned this pull request Jul 24, 2026

ayon-ui-qt browser #1740

Closed

4 tasks

- removed duplicate import

75eb8d0

mahesh-ynput changed the base branch from develop to ui-qt-browser July 24, 2026 08:21

mahesh-ynput force-pushed the ui-qt-browser_view_fixes branch from 4ad922f to 75eb8d0 Compare July 25, 2026 04:17

Mahesh1651 added 6 commits July 25, 2026 09:50

- _review_table.py view button size to match with other buttons

b5a5631

- _review_table.py clearing applied filters on deletion of view - view_selector.py capturing current UI state into the view before editing so it can save the changes

- add signal for modified view filters and update the state, This can…

6c44844

… later help to highlight view button upon any modifications in view

- added set_variant to AYButton it will allow to change the button st…

b9dd42f

…yle after init in buttons.py - Changing "view" menubutton color to blue same as web when any filter is modified in view_selector.py

- show save button on current view row when filters are modified on c…

a1a2d10

…lick save silently save as in web

BigRoy reviewed Jul 26, 2026

View reviewed changes

ynbot added this to PR reviewing Jul 26, 2026

ynbot moved this to Review In Progress in PR reviewing Jul 26, 2026

Mahesh1651 added 2 commits July 27, 2026 13:31

- Added access levels to match with current web constants going to us…

d4c6441

…e them further - improved filter capture method by using view bindings

- simplified _make_row by extract _make_save_btn and _make_edit_btn h…

21dd7f3

…elpers - added _HoverReveal filter to match UX match with web.

Mahesh1651 added 2 commits July 27, 2026 20:35

- keep constant "Working view" at top first all time

c5e14ec

- added default view section for studio and project default view

- align views visibility of views to same as web private/public

1af9116

- removed legacy visibility fallback and enforce web format payload validation in desktop models/tests

BigRoy reviewed Jul 28, 2026

View reviewed changes

Comment thread client/ayon_core/ui/components/views/view_selector.py Outdated

iLLiCiTiT reviewed Aug 27, 2026

View reviewed changes

Comment thread client/ayon_core/ui/components/views/default_view_control.py Outdated

Mahesh1651 and others added 3 commits August 30, 2026 10:21

- add width and height overrides to AYButton and update size handling

1ef71bd

- refactor default view settings move constants to default_view_contr…

942e055

…ol.py and update ViewSettings

Update client/ayon_core/ui/components/views/default_view_control.py

06d8b7f

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

iLLiCiTiT reviewed Sep 2, 2026

View reviewed changes

BigRoy closed this Sep 11, 2026

github-project-automation Bot moved this from Review In Progress to Done in PR reviewing Sep 11, 2026

BigRoy added a commit that referenced this pull request Sep 11, 2026

Include some fixes from #1970 and implements some of the pending comm…

e05b6f0

…ents there

	widget.deleteLater()
	widget.setVisible(False)
	widget.deleteLater()

	working = self._ensure_working_view_exists()
	working_view = self._ensure_working_view_exists()

	for user in self.usernames_and_groups.get("users", []):
	for user in self.usernames_and_groups["users"]:

	if user.get("name") == user_name:
	if user["name"] == user_name:

	users = ayon_api.get_users(project_name=project_name) or []
	users = ayon_api.get_users(project_name=project_name)

	user_full_name = user.get("fullName", "") or user_name
	user_full_name = user["fullName"] or user_name

Conversation

mahesh-ynput commented Jul 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog Description

Additional info

Testing notes:

Uh oh!

mahesh-ynput commented Jul 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BigRoy commented Jul 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mahesh-ynput commented Jul 27, 2026

Uh oh!

mahesh-ynput commented Jul 27, 2026

Uh oh!

BigRoy commented Jul 27, 2026

Uh oh!

Uh oh!

mahesh-ynput commented Jul 29, 2026

Uh oh!

iLLiCiTiT Aug 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iLLiCiTiT Sep 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mahesh-ynput commented Jul 24, 2026 •

edited

Loading

mahesh-ynput commented Jul 24, 2026 •

edited

Loading

BigRoy commented Jul 24, 2026 •

edited

Loading

iLLiCiTiT Aug 27, 2026 •

edited

Loading

iLLiCiTiT Sep 2, 2026 •

edited

Loading