Skip to content

Workfiles tool: disable file extension combobox in "Copy & Open" - #2017

Merged
iLLiCiTiT merged 18 commits into
developfrom
1118-workfiles-tool-published-copy-open---invalidly-prompts-for-save-file-extension
Sep 4, 2026
Merged

Workfiles tool: disable file extension combobox in "Copy & Open"#2017
iLLiCiTiT merged 18 commits into
developfrom
1118-workfiles-tool-published-copy-open---invalidly-prompts-for-save-file-extension

Conversation

@tadeas-hejnic

@tadeas-hejnic tadeas-hejnic commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Changelog Description

This PR disables file extension change during Copy & Open action in work files tool.

It is done via adding new argument enable_ext_selection and disabling the combobox based on this passed argument value.

Additional info

N/A

Testing notes:

  1. Open the workfiles tool in DCC
  2. Click on Copy & Open button

@tadeas-hejnic tadeas-hejnic self-assigned this Aug 26, 2026
@tadeas-hejnic tadeas-hejnic added the type: bug Something isn't working label Aug 26, 2026
@ynbot ynbot added the size/XS label Aug 26, 2026
@tadeas-hejnic
tadeas-hejnic requested a lite review from Copilot August 26, 2026 09:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Workfiles tool UI so that when using the “Copy & Open” flow, the user can no longer change the target file extension in the Save As dialog—preventing mismatches between the selected published representation and the destination extension.

Changes:

  • Added an enable_ext_selection flag to SaveAsDialog to disable the extension combobox when needed.
  • Threaded an enable_ext_selection option through FilesWidget._exec_save_as_dialog(...).
  • Wired the “Copy & Open” button to open the dialog with extension selection disabled.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
client/ayon_core/tools/workfiles/widgets/save_as_dialog.py Adds an option to disable the extension combobox in the Save As dialog.
client/ayon_core/tools/workfiles/widgets/files_widget.py Passes the new flag through dialog creation and disables extension selection for “Copy & Open”.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread client/ayon_core/tools/workfiles/widgets/files_widget.py Outdated
Comment thread client/ayon_core/tools/workfiles/widgets/files_widget.py Outdated
Comment thread client/ayon_core/tools/workfiles/widgets/files_widget.py Outdated
@ynbot ynbot moved this to Review In Progress in PR reviewing Aug 26, 2026
Comment thread client/ayon_core/tools/workfiles/widgets/files_widget.py Outdated
Comment thread client/ayon_core/tools/workfiles/widgets/files_widget.py Outdated
Comment thread client/ayon_core/tools/workfiles/widgets/files_widget.py Outdated
Comment thread client/ayon_core/tools/workfiles/widgets/save_as_dialog.py Outdated
Comment thread client/ayon_core/tools/workfiles/widgets/save_as_dialog.py Outdated
Comment thread client/ayon_core/tools/workfiles/widgets/save_as_dialog.py Outdated
Comment thread client/ayon_core/tools/workfiles/widgets/files_widget.py Outdated
Comment thread client/ayon_core/tools/workfiles/widgets/save_as_dialog.py Outdated
Comment thread client/ayon_core/tools/workfiles/widgets/files_widget.py Outdated
tadeas-hejnic and others added 2 commits August 31, 2026 14:10
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Comment thread client/ayon_core/tools/workfiles/widgets/files_widget.py Outdated
Comment thread client/ayon_core/tools/workfiles/widgets/save_as_dialog.py Outdated
Comment thread client/ayon_core/tools/workfiles/widgets/save_as_dialog.py Outdated
tadeas-hejnic and others added 5 commits August 31, 2026 15:28
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
@github-project-automation github-project-automation Bot moved this from Review In Progress to Merge Requested in PR reviewing Sep 4, 2026
@iLLiCiTiT
iLLiCiTiT merged commit d496db3 into develop Sep 4, 2026
4 checks passed
@iLLiCiTiT
iLLiCiTiT deleted the 1118-workfiles-tool-published-copy-open---invalidly-prompts-for-save-file-extension branch September 4, 2026 09:02
@github-project-automation github-project-automation Bot moved this from Merge Requested to Done in PR reviewing Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS type: bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Workfiles tool > Published > Copy & Open - invalidly prompts for save file extension

4 participants