Skip to content

Escaped bash special characters for bash command #2033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iLLiCiTiT merged 3 commits into from
Sep 4, 2026
Merged

Escaped bash special characters for bash command #2033

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
19464e8
Escaped bash special characters for bash command
kalisp Sep 2, 2026
0d6f055
Merge branch 'develop' into enhancement/YN-1008_handle_special_chars_…
kalisp Sep 3, 2026
926662d
Merge branch 'develop' into enhancement/YN-1008_handle_special_chars_…
iLLiCiTiT Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion client/ayon_core/lib/execute.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,15 @@ def run_subprocess(*args, **kwargs):
and isinstance(args[0], str)
):
# Escape parentheses for bash
if os.getenv("SHELL") in ("/bin/bash", "/bin/sh"):
if platform.system().lower() != "windows":
new_arg = (
args[0]
.replace("&", "\\&")
.replace(";", "\\;")
.replace("|", "\\|")
.replace("$", "\\$")
.replace(">", "\\>")
Comment on lines +122 to +126

@BigRoy BigRoy Sep 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kalisp is this something you can validate?

@kalisp kalisp Sep 3, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was testing it on uploading video_v001_b&w.mp4 via Webpublisher service (which is running on Linux). Tray publisher on Linux/MacOS would do the trick too.

@iLLiCiTiT iLLiCiTiT Sep 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't use shell=False if that's what you're asking for?

.replace("<", "\\<")
.replace("(", "\\(")
.replace(")", "\\)")
)
Expand Down
Loading