Skip to content

Adjust shot handle clamp and log a warning. - #178

Open
rdelillo wants to merge 1 commit into
developfrom
bugfix/176_clamp_shot_handles
Open

rdelillo wants to merge 1 commit into
developfrom
bugfix/176_clamp_shot_handles

Conversation

@rdelillo

Copy link
Copy Markdown
Collaborator

Changelog Description

fixes: #176
Changes:

  • Ensure creator_attributes are not edited directly
  • Added log.warning when handles are reduced

Additional review information

image

Testing notes:

  1. Attempt to ingest a shot from a plate with no available handles
  2. Ensure the handles are properly reduced and the warning appears in the log

@rdelillo
rdelillo requested a balanced review from Copilot October 20, 2026 22:36
@rdelillo rdelillo self-assigned this Oct 20, 2026
@rdelillo rdelillo added the type: enhancement Improvement of existing functionality or minor addition label Oct 20, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused changes preserve downstream handle propagation and creator settings, with no blocking issues identified.

No open issues 🎉

What changed in this PR

Addresses #176 by clamping shot handles without modifying creator attributes and warning when available media limits handles.

Changes:

  • Preserve creator attributes while passing clamped handles to instance and shared editorial data.
  • Log separate warnings for reduced head and tail handles.
File Description
client/​ayon_flame/​plugins/​publish/​collect_shots.py Copy attributes for handle clamping, propagate resolved values, and log reductions.

Review effort: Balanced

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement Improvement of existing functionality or minor addition

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shots: clamp handles on instance data only and log reductions

2 participants