Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused changes preserve downstream handle propagation and creator settings, with no blocking issues identified.
No open issues 🎉
What changed in this PR
Addresses #176 by clamping shot handles without modifying creator attributes and warning when available media limits handles.
Changes:
- Preserve creator attributes while passing clamped handles to instance and shared editorial data.
- Log separate warnings for reduced head and tail handles.
| File | Description |
|---|---|
| client/ayon_flame/plugins/publish/collect_shots.py | Copy attributes for handle clamping, propagate resolved values, and log reductions. |
Review effort: Balanced
This was referenced Oct 27, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
fixes: #176
Changes:
Additional review information
Testing notes: