Conversation
…k if the model product to avoid model publish twice.
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
BigRoy
left a comment
BigRoy
left a comment
There was a problem hiding this comment.
Nice - this could work.
I think we'll need to add a dedicated additional family to target this plug-in:
So we can still have it apply for the mayaUsd ones but can also enable it for this one without it by default supporting model family, e.g. a mayaUsd.filterProperties family or alike?
…nts-when-Exposed-Overrides
|
@BigRoy can you review? |
There was a problem hiding this comment.
Code LGTM - but didn't have time to test now. @LiborBatek any chance you can give it a go today?
- Maya USD family should still work
- Maya USD: Model product should work, display attributes correctly and integrate with USD file correctly.
- I think we may have an issue here @moonyuet because I think this one will now also export the default
modeloutputs which it previously didn't if I'm not mistaken. I believe previously it ONLY exported the USD. Can you confirm?
- I think we may have an issue here @moonyuet because I think this one will now also export the default
- Regular model product also still works, without USD
There was a problem hiding this comment.
Pull request overview
Routes Maya USD Model instances through a single USD extractor to prevent duplicate options and exports.
Changes:
- Adds a dedicated filter-properties family.
- Removes Maya USD Model instances from the general extractor family.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
collect_maya_usd_export_filter_properties.py |
Supports the dedicated filter-properties family. |
create_maya_usd.py |
Updates Maya USD Model publish families. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| return attr_defs | ||
|
|
||
| def get_publish_families(self): | ||
| return ["model", "usd", "mayaUsd.filterProperties"] |
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
LiborBatek
left a comment
LiborBatek
left a comment
There was a problem hiding this comment.
I have tested through publishing of the model mayaUSD:Model and MayaUSD:usdAsset as model and all been publishing successfully.
I havent experienced any duplication of the USD overrides while having those enabled (aka exposed)...all good on this front.
LGTM
P.S. one small thing Im curious about is if when using standard modelMain and having enabled ayon+settings://maya/publish/ExtractMayaUsd if the USD representation could be as optional as I couldnt achieve it and it was always produced too leading to e.g. .ma .abc and .usd allways... Im not saying its a flaw but been curious if it is correct or not. @BigRoy
Standard |
It could have been because the last commit inheriting unnecessary class. It should be cleaned up and I have added the |
However, with this change - then we don't get the enforced disabling of the |
It is not retained anymore. |
…nts-when-Exposed-Overrides
…nts-when-Exposed-Overrides
BigRoy
left a comment
BigRoy
left a comment
There was a problem hiding this comment.
@LiborBatek can you validate this works for you?
I'll want to think a bit more about the model.extract naming - but admittedly, it's not required for getting this merged. So, approving. If this works, I'm all good.
|
@moonyuet I've noticed that for 
|
…on in ExtractAlembic
|
@BigRoy @LiborBatek can you review again? |
Changelog Description
This PR is to remove the duplicate overrides in USD options in MayaUSD publish. This also avoids the two extractors exporting the assets twices which error out the integrator.
Resolve #461
Additional review information
Marked it as draft as it needs more clarification for the legacy creator.
Testing notes: