Reuse check inventory versions for loader colors by vincentullmann · Pull Request #278 · ynput/ayon-nuke

vincentullmann · 2026-06-26T16:37:49Z

Changelog Description

refactor the tile_color logic to be shared between loaders. Updated the check_inventory_versions to use the same logic as the loader for consistent color coding

Additional review information

before:

each Loader re-implements the is_latest checks to update the node colors
check_inventory_versions runs on scriptSave and uses its own logic and own color values to update the node colors
loading an older version of a product incorrectly used the latest color

after:

plugin.NukeLoader.get_node_colors returns a map of "container_status/categories" to colors
- those values can be overwritten either by setting the respective node_color_<status> variables on the LoaderClass
- or by overwriting get_node_colors and return different values
plugin.NukeLoader.update_node_color(self, node) a helper method to update the tile color for a given node. Loaders should use this on load and update
check_inventory_versions now uses the colors defined by each containers get_node_colors

Todo:

so far I've only updated the LoadClip and LoadImage loaders as examples. If the general approach is approved I'm happy to roll out the updates to other loaders too.

Testing notes:

import a product using the LoadClip or LoadImage loader
=> confirm that the correct color (latest) was used
change the version to an older one
=> confirm that the correct color was used (outdated color)
change it back to latest
=> confirm that the correct color (latest) was used
load a outdated version of a product
=> confirm that the correct color was used (outdated color)
save the workfile (this should trigger the onScriptSave callback: check_inventory_versions
confirm that all nodes have the correct colors

…r container

…_colors

BigRoy · 2026-07-02T08:30:21Z

@vincentullmann can you resolve the linter issues?

…_colors

moonyuet · 2026-07-07T07:48:38Z

+    node_color_invalid    = color_to_int(255, 0, 0)    # 0xff0000ff
+    node_color_not_found  = color_to_int(255, 255, 0)  # 0xffff00ff
+    node_color_latest     = color_to_int(78, 205, 37)  # 0x4ecd25ff
+    node_color_outdated   = color_to_int(216, 79, 32)  # 0xd84f20ff


@BigRoy @vincentullmann Guess it might be good idea to put it into the addon settings and users can customize their own colors for these nodes?

yeah, I like the idea.

On that note: When I was going trough each loader and updating the logic I noticed that, the defaults I've picked based on LoadCLip get overwritten often by the same colors.

here is a table showing what colors are currently being used:

Loader invalid not_found latest outdated

NukeLoader

LoadClip default default default default

LoadImage default default default default

LinkAsGroup default default

AlembicModelLoader default default

GeoImportLoader default default

GeoReferenceLoader default default

LoadOcioLookNodes default default

AlembicCameraLoader default default

FbxCameraLoader default default

UsdCameraLoader default default

This raises the questions:

a) Should each loader have their own server settings?

b) or should we unify the colors? eg.: latest always and outdated always ?

c) or group them up and give each group a set of server settings?
for example

2D Nodes (Clip, Image)

Model and Geo

*CameraLoaders

not sure where LinkAsGroup and LoadOcioLookNodes would fit in

Note on b):
If we unify the colors, we could simplify the code as well. Currently there is some work done to allow each loader to define its own colors, which would be unnecessary, if we'd pick that option

If there's need for c) then I think we should go for a) and allow customizing all separately.
If no need to differentiate between each, I think b) is the best option.

My vote would go for b) but one may like to change to 3d nodes to a different color from the read nodes (especially in the case of not-outdated) which would require a). I don't have Nuke experience so hard to tell what a user would prefer there. @jakubjezek001 @rdelillo preferences?

Copilot

🟡 Changes recommended

The updated inventory-coloring path can break when loaders don’t implement get_node_color, a precomp latest color value appears incorrect, and USD camera load no longer sets the prim path on initial load.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR refactors node tile-coloring for loaded containers so both individual loaders and check_inventory_versions use a shared, loader-driven color mapping based on container version status (latest/outdated/invalid/not_found), aiming for consistent color coding across the integration.

Changes:

Introduces NukeLoader.get_node_color() + NukeLoader.update_node_color() helpers and shifts multiple loaders to inherit from plugin.NukeLoader.
Updates check_inventory_versions to resolve colors via the loader class (instead of a global constants mapping) and adds color_to_int utility for consistent int conversion.
Removes the legacy LOADER_CATEGORY_COLORS constant and replaces per-loader “is latest” checks with shared logic.

File summaries

File	Description
client/ayon_nuke/plugins/load/load_usd.py	Switches USD geo loaders to `NukeLoader` and uses shared node-color update after containerisation/updates.
client/ayon_nuke/plugins/load/load_script_precomp.py	Switches precomp loader to `NukeLoader` and delegates tile-color to shared logic with per-loader overrides.
client/ayon_nuke/plugins/load/load_ociolook.py	Switches ocio look loader to `NukeLoader` and removes custom version-color logic in favor of shared update.
client/ayon_nuke/plugins/load/load_model.py	Switches model loader to `NukeLoader` and removes custom version-color logic in favor of shared update.
client/ayon_nuke/plugins/load/load_image.py	Switches image loader to `NukeLoader` and removes custom version-color logic in favor of shared update.
client/ayon_nuke/plugins/load/load_clip.py	Removes custom version-color logic and uses shared `update_node_color` on load/update.
client/ayon_nuke/plugins/load/load_camera.py	Switches camera loader to `NukeLoader` and removes custom version-color logic in favor of shared update.
client/ayon_nuke/plugins/load/load_camera_usd.py	Switches USD camera loader to `NukeLoader` and delegates tile-coloring to shared logic.
client/ayon_nuke/api/plugin.py	Adds node-color defaults and helper methods on `NukeLoader` for centralized color selection and updates.
client/ayon_nuke/api/lib.py	Refactors `check_inventory_versions` to consult loader-provided colors; adds `color_to_int` conversion helper.
client/ayon_nuke/api/constants.py	Removes the legacy global loader category->color mapping constant.

Review details

Files reviewed: 11/11 changed files
Comments generated: 3
Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

+                loader_name = container.get("loader")
+                if not loader_name:
+                    continue
+
+                loader = loaders_by_name.get(loader_name)
+                if not loader:
+                    continue
+
+                if color := loader.get_node_color(category):
+                    container["node"]["tile_color"].setValue(color)


+    node_color_latest =   color_to_int(255, 255, 255)  # 0xff0ff0ff
+    node_color_outdated = color_to_int(216, 79, 32)    # 0xd84f20ff


            camera_node.forceValidate()
            camera_node["frame_rate"].setValue(float(fps))

-        # color node by correct color by actual version
-        self.node_version_color(
-            context["project"]["name"], version_entity, camera_node
-        )
-
-        self.set_usd_camera_prim_path(camera_node)
-
-        return containerise(
+        container = containerise(
            node=camera_node,


jakubjezek001 · 2026-09-01T13:49:02Z

closing for #364

vincentullmann added 5 commits June 26, 2026 17:12

add color_to_int

30abfae

add NukeLoader.get_node_colors and update_node_color

e608a7b

update check_inventory_versions to use the loaders get_node_colors pe…

66e6884

…r container

update load_clip to use the shared tile_color logic

2c7a354

update LoadImage

b84e6a1

BigRoy requested a review from jakubjezek001 June 29, 2026 09:49

BigRoy assigned jakubjezek001 Jun 29, 2026

BigRoy added type: enhancement Improvement of existing functionality or minor addition sponsored This is directly sponsored by a client or community member labels Jun 29, 2026

vincentullmann added 4 commits June 29, 2026 10:52

Merge branch 'develop' into reuse_check_inventory_versions_for_loader…

a795084

…_colors

remove unused imports

5133957

move is_library and is_other_project into get_node_color

5ec4c6e

update check_inventory_versions to use get_node_color

efaa971

vincentullmann mentioned this pull request Jun 29, 2026

add library type to ContainersFilterResult ynput/ayon-core#1908

Closed

BigRoy reviewed Jun 29, 2026

View reviewed changes

Comment thread client/ayon_nuke/api/plugin.py Outdated

Comment thread client/ayon_nuke/api/plugin.py Outdated

Comment thread client/ayon_nuke/api/plugin.py Outdated

vincentullmann added 4 commits July 1, 2026 13:18

remove library and other_project logic

b546b5b

use update_node_color in UsdCameraLoader

342dd02

use update_node_color in AlembicCameraLoader

a4143ab

use update_node_color in most other loaders

8f48823

vincentullmann added 3 commits July 2, 2026 10:18

Merge branch 'develop' into reuse_check_inventory_versions_for_loader…

0ba5738

…_colors

fix linter issues

060a000

Merge branch 'develop' into reuse_check_inventory_versions_for_loader…

3809b10

…_colors

moonyuet reviewed Jul 7, 2026

View reviewed changes

jakubjezek001 requested a lite review from Copilot September 1, 2026 12:54

Copilot started reviewing on behalf of jakubjezek001 September 1, 2026 12:54 View session

Copilot AI reviewed Sep 1, 2026

View reviewed changes

jakubjezek001 mentioned this pull request Sep 1, 2026

Reuse check inventory versions for loader colors YN #364

Open

jakubjezek001 closed this Sep 1, 2026

Navigation Menu

Uh oh!

Reuse check inventory versions for loader colors - #278

Reuse check inventory versions for loader colors#278
vincentullmann wants to merge 16 commits into
ynput:developfrom
straylondon:reuse_check_inventory_versions_for_loader_colors

vincentullmann commented Jun 26, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BigRoy commented Jul 2, 2026

Uh oh!

moonyuet Jul 7, 2026

Uh oh!

vincentullmann Jul 7, 2026 •

edited

Loading

Uh oh!

vincentullmann Jul 7, 2026

Uh oh!

BigRoy Jul 7, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

jakubjezek001 commented Sep 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Loader	invalid	not_found	latest	outdated
`NukeLoader`
`LoadClip`	default	default	default	default
`LoadImage`	default	default	default	default
`LinkAsGroup`	default	default
`AlembicModelLoader`	default	default
`GeoImportLoader`	default	default
`GeoReferenceLoader`	default	default
`LoadOcioLookNodes`	default	default
`AlembicCameraLoader`	default	default
`FbxCameraLoader`	default	default
`UsdCameraLoader`	default	default

		node_color_latest = color_to_int(255, 255, 255) # 0xff0ff0ff
		node_color_outdated = color_to_int(216, 79, 32) # 0xd84f20ff

Uh oh!

Conversation

vincentullmann commented Jun 26, 2026

Changelog Description

Additional review information

Testing notes:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BigRoy commented Jul 2, 2026

Uh oh!

moonyuet Jul 7, 2026

Choose a reason for hiding this comment

Uh oh!

vincentullmann Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vincentullmann Jul 7, 2026

Choose a reason for hiding this comment

Uh oh!

BigRoy Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

jakubjezek001 commented Sep 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

vincentullmann Jul 7, 2026 •

edited

Loading

BigRoy Jul 7, 2026 •

edited

Loading