Skip to content

feature: add Comfystream management api #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

feature: add Comfystream management api #56

wants to merge 11 commits into from

Conversation

@ad-astra-video
Copy link
Collaborator

@ad-astra-video ad-astra-video commented Feb 8, 2025

Add API to install and remove nodes/models for comfystream and comfyui.

Routes are for management per discussion in Notion doc.

@ad-astra-video
Copy link
Collaborator Author

ad-astra-video commented Feb 13, 2025

@eliteprox @rickstaa I pushed up my latest updates. I have successfully reloaded the nodes now but it is very hacky and needs tested more. Please let me know your feedback.

The /env/reload route reloads the nodes and creates a new EmbeddedComfyClient. Below is my postman collection for the API routes with the YOLO node saved to install and delete.
comfystream api.postman_collection.json

Steps to reload client:

  1. Load a workflow and run a few frames (needed because the EmbeddedComfyClient does not load comfy ui until work is sent).
    _passthrough_workflow.json
  2. Install a node not in current set (i installed YOLO object detection nodes)
  3. run new workflow that requires the node installed (3 - SD 1.5 TensorRT workflow - ultralytics.json)

Questions to test:

  1. Does the current stream need to be stopped to reload the EmbeddedComfyClient (e.g. fresh comfystream UI before calling /env/reload)
  2. Does this hacky way of unloading and loading the imports and EmbeddedComfyClient cause other problems?

@eliteprox eliteprox mentioned this pull request Mar 13, 2025
Closed
hjpotter92
hjpotter92 reviewed Mar 17, 2025
View reviewed changes
server/api/api.py
app.router.add_post("/env/delete_models", delete_models)

app.router.add_post("/env/reload", reload)
app.router.add_post("/env/set_account_info", set_account_info)
Copy link
Collaborator

@hjpotter92 hjpotter92 Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit: would suggest the root path to be /settings or /config instead of /env.

This was referenced Mar 17, 2025
Closed
Open
Open
JJassonn69 pushed a commit to JJassonn69/comfystream that referenced this pull request Apr 1, 2025
@eliteprox
changes supporting ai-runner upgrade to comfystream 0.0.4 (yondonfu#56)
d92a6f5 
* set comfystream as default conda env

add ffmpeg6, use conda-forge
dockerfile cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hjpotter92 hjpotter92 hjpotter92 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ad-astra-video @hjpotter92