Skip to content

Add precision option to oklch output #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jpc-ae wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add precision option to oklch output #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions lib/colorConversion.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,20 +198,19 @@ function formatOKLAB(oklab: OKLAB, simplified = false, useCommas = false): strin
return `oklab(${oklab.l.toFixed(2)}${separator}${oklab.a.toFixed(2)}${separator}${oklab.b.toFixed(2)})`;
}

function formatOKLCH(oklch: OKLCH, simplified = false, useCommas = false): string {
function formatOKLCH(oklch: OKLCH, simplified = false, useCommas = false, increasePrecision = true): string {
const separator = useCommas ? ', ' : ' ';
const lPrecision = increasePrecision ? 3 : 2;
const cPrecision = increasePrecision ? 3 : 2;
const hPrecision = increasePrecision ? 2 : 0;
const aPrecision = increasePrecision ? 3 : 2;

// Only include alpha if it exists and is not 0 or extremely close to 0
const includeAlpha = oklch.alpha !== undefined && oklch.alpha !== 1 && oklch.alpha > 0.001;

if (simplified) {
return `${oklch.l.toFixed(2)}${separator}${oklch.c.toFixed(2)}${separator}${Math.round(oklch.h)}${includeAlpha ? ` / ${(oklch.alpha! * 100).toFixed(0)}%` : ''}`;
}
// Only include alpha if it is valid
const includeAlpha = oklch.alpha !== undefined && 1 > oklch.alpha && oklch.alpha > 0.001;

const values = `${oklch.l.toFixed(lPrecision)}${separator}${oklch.c.toFixed(cPrecision)}${separator}${oklch.h.toFixed(hPrecision)}${includeAlpha ? ` / ${oklch.alpha.toFixed(aPrecision)}` : ''}`

if (includeAlpha) {
return `oklch(${oklch.l.toFixed(2)}${separator}${oklch.c.toFixed(2)}${separator}${Math.round(oklch.h)} / ${(oklch.alpha! * 100).toFixed(0)}%)`;
}
return `oklch(${oklch.l.toFixed(2)}${separator}${oklch.c.toFixed(2)}${separator}${Math.round(oklch.h)})`;
return simplified ? values : `oklch(${values})`;
}

// Function to convert alpha value (0-1) to hex string (00-FF)
Expand Down Expand Up @@ -634,4 +633,5 @@ export function processMultiLineInput(
detectedFormat: detectedFormat || undefined
};
});
}

}