Retry initial database connection until it succeeds - #16
Merged
yungcomputerchair merged 7 commits intoApr 29, 2026
Conversation
dongresource
force-pushed
the
wait-for-db
branch
from
April 11, 2026 01:30
e76d92e to
a77a1a3
Compare
dongresource
force-pushed
the
wait-for-db
branch
from
April 24, 2026 19:41
a77a1a3 to
cc2e56c
Compare
dongresource
force-pushed
the
wait-for-db
branch
from
April 28, 2026 12:08
cc2e56c to
4d000c6
Compare
dongresource
force-pushed
the
wait-for-db
branch
from
April 28, 2026 12:09
4d000c6 to
81c4489
Compare
dongresource
marked this pull request as ready for review
April 28, 2026 20:32
dongresource
marked this pull request as draft
April 28, 2026 23:40
dongresource
force-pushed
the
wait-for-db
branch
from
April 28, 2026 23:45
d32e156 to
2efcd0a
Compare
Collaborator
Author
|
Might want to look at the choices of error severity a bit closer to make sure they make sense. Especially with how |
dongresource
marked this pull request as ready for review
April 29, 2026 00:03
dongresource
changed the title
dongresource
added a commit
that referenced
this pull request
Apr 29, 2026
The initial DB connection now retries on a timer, allowing the login and shard servers to be started before the database. * Failure to reach the DB prints a simple, readable error message * Other DB connection errors like auth failures print more detailed error messages * Improved underlying error message extraction from errors on other DB operations as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The initial DB connection now retries on a timer, allowing the login and shard servers to be started before the database.