-
-
Notifications
You must be signed in to change notification settings - Fork 14
Ignore events on hidden elements #280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Great job! No new security vulnerabilities introduced in this pull requestUse @Checkmarx to reach out to us for assistance. Just send a PR comment with Examples: |
c7d57c0 to
5263af5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
This one is good too, it's more specific to check if visible in viewport but points out things like: |
|
Right now I'd rather go with a "good enough" rather than a "perfect" solution .. esp as the test cases take significantly more effort than the implementation, but happy to be overruled... |
Signed-off-by: Simon Bennetts <[email protected]>
5263af5 to
55428b4
Compare
|
Thank you! |

No description provided.