Skip to content

Conversation

@psiinon
Copy link
Member

@psiinon psiinon commented Dec 10, 2025

No description provided.

@psiinon
Copy link
Member Author

psiinon commented Dec 10, 2025

Logo
Checkmarx One – Scan Summary & Details81869f1a-1da2-427e-906d-1d8e422bfd0d

Great job! No new security vulnerabilities introduced in this pull request


Use @Checkmarx to reach out to us for assistance.

Just send a PR comment with @Checkmarx followed by a natural language request.

Examples: @Checkmarx how are you able to help me? @Checkmarx rescan this PR

@psiinon psiinon force-pushed the recorder/ignore-hidden branch from c7d57c0 to 5263af5 Compare December 10, 2025 13:24
Copy link
Member

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kingthorin
Copy link
Member

kingthorin commented Dec 10, 2025

This one is good too, it's more specific to check if visible in viewport but points out things like: clip-path: circle(0); and
transform: scale(0); which you may also need to account for.
https://marco-prontera.medium.com/now-you-see-me-is-in-viewport-javascript-efa19b20b063

@psiinon
Copy link
Member Author

psiinon commented Dec 10, 2025

Right now I'd rather go with a "good enough" rather than a "perfect" solution .. esp as the test cases take significantly more effort than the implementation, but happy to be overruled...

Signed-off-by: Simon Bennetts <[email protected]>
@psiinon psiinon force-pushed the recorder/ignore-hidden branch from 5263af5 to 55428b4 Compare December 10, 2025 15:24
@thc202 thc202 merged commit f421dbe into zaproxy:main Dec 11, 2025
6 checks passed
@thc202
Copy link
Member

thc202 commented Dec 11, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants