Skip to content

be more efficient by reusing the response of create and update #3448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

be more efficient by reusing the response of create and update #3448

wants to merge 1 commit into from

Conversation

@grosser
Copy link
Contributor

@grosser grosser commented Jul 11, 2019

this fails because deployment deletion logic is very complicated and tests break when we do not fake a 404 to avoid rollback

@grosser grosser requested a review from a team as a code owner July 11, 2019 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@uthark uthark uthark approved these changes

@eatwithforks eatwithforks eatwithforks approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@grosser @uthark @eatwithforks