fix: preserve PolicyFlags through serialize/deserialize cycle for permission validator#262
Open
bergusman wants to merge 1 commit intozerodevapp:mainfrom
Open
fix: preserve PolicyFlags through serialize/deserialize cycle for permission validator#262bergusman wants to merge 1 commit intozerodevapp:mainfrom
bergusman wants to merge 1 commit intozerodevapp:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug:
PolicyFlagslost afterdeserializePermissionAccountProblem
When serializing a
KernelAccountthat usestoPermissionValidatorwith a customflag(e.g.PolicyFlags.NOT_FOR_VALIDATE_SIG), the flag is not preserved through the serialize/deserialize cycle.After
deserializePermissionAccount, the reconstructed validator uses the default flag value, causing a mismatch inenableSig— which makes the resulting account unable to send UserOps.Reproduction
Root Cause
serializePermissionAccountdoes not include theflagfield from the permission validator in the serialized payload. Consequently,deserializePermissionAccountreconstructs the validator without it, defaulting toPolicyFlags.FOR_ALL_VALIDATION.Fix
Include
flagin the serialized permission account data and pass it back totoPermissionValidatorduring deserialization.Impact
Any flow that relies on not default
FOR_ALL_VALIDATION(e.g. session keys used purely forexecutewithout signature validation) is broken when accounts are serialized and shared between server and client.