Skip to content

Conversation

@notcancername
Copy link
Contributor

the zero terminator was included in the output of
HostName.expand, which would try and fail to HostName.validate it
because it contained a zero byte

closes #25811

to the zero terminator was included in the output of
`HostName.expand`, which would try and fail to `HostName.validate` it
because it contained a zero byte

closes ziglang#25811
@notcancername
Copy link
Contributor Author

CI failure seems spurious:

Main test suite...
test
+- test-incremental
   +- incr-check 'add_decl_namespaced' failure
warning: failed to delete tree 'tmp_7beb1e3fe3d5fb1d': FileBusy
error: expected compile errors but compilation incorrectly succeeded
error: process exited with code 1 (expected exited with code 0)

@squeek502
Copy link
Member

Thanks for the fix, apologies for not seeing this sooner.

I'm going to take #25909 instead just because the test data is a bit nicer, and because anything depending on the NUL byte being written is a bug that should be found and fixed, as the sentinel is not encoded in the returned type.

@squeek502 squeek502 closed this Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DNS resolution fails for URIs with a www subdomain

2 participants