std.zig.AstGen: properly handle grouped_expression #25849
Merged
+10
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateusz834
force-pushed
the
fix-endless-loop-astgen
branch
2 times, most recently
from
98e303d to
8750166
Compare
Member
|
The bugfix looks fine, but I don't really like the second commit; I disagree that it's a simplification and I think it makes the logic read worse. If you drop the second commit I'll be happy to merge the first as-is. |
This fixes an endless loop in the compiler.
mateusz834
force-pushed
the
fix-endless-loop-astgen
branch
from
8750166 to
8f07a60
Compare
Contributor
Author
|
@mlugg updated |
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug, endless loop in AstGen.