Adding functionality for collecting information via the PPTP protocol #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hey @SergoRoberto, thanks for the pull request and apologies for it taking half a year to get to this! Looks like this adds support for 4 new modules but we'll need to add integration tests against a dockerized service that we'll scan against. If you can follow the examples in integration_tests and add them, we can get this merged. |
Author
|
hi @phillip-stephens , i'm very lazy to do anything other than developing modules, if you want to add, do it yourself, understand correctly, i don't have much time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding functionality for collecting information via the PPTP protocol
Notes & Caveats
A noble desire to expand the functionality, add a line to the resume