Skip to content

Conversation

@hrishikesh-nalawade
Copy link
Member

@hrishikesh-nalawade hrishikesh-nalawade commented Dec 10, 2025

Description

API-Layer filters out its own certificates during client authentication but doesn't log which certificates were ignored, making troubleshooting difficult.

  • Created shared CertificateLoggingUtils utility class for certificate logging
  • Added logging to both CategorizeCertsFilter and CategorizeCertsWebFilter

Linked to #4164

Type of change

Please delete options that are not relevant.

  • fix: Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

certificateForClientAuth
);

// Log ignored certificates
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the comments needed? The method name is self-explanatory

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, will remove most of the comments after after review and before merging.

@pablocarle
Copy link
Contributor

What about microservices' mode CategorizeCertsFilter? Do we want to print it also there? It's still the most used configuration mode and it may be helpful to have more diagnostics there

@pablocarle
Copy link
Contributor

Does the PR fix #4164 fully? The issue also refers to documentation update

@hrishikesh-nalawade
Copy link
Member Author

hrishikesh-nalawade commented Dec 10, 2025

What about microservices' mode CategorizeCertsFilter? Do we want to print it also there? It's still the most used configuration mode and it may be helpful to have more diagnostics there

Thank You for pointing that out, I was not aware of that. I'll implement the changes in CategorizeCertsFilter as well.

…ld be done in CategorizeCertsFilter and CategorizeCertsWebFilter

Signed-off-by: hrishikesh-nalawade <[email protected]>
@hrishikesh-nalawade hrishikesh-nalawade changed the title Fix: Log ignored certificates during client authentication fix: Log ignored certificates during client authentication Dec 10, 2025
@github-actions github-actions bot added the Sensitive Sensitive change that requires peer review label Dec 10, 2025
Signed-off-by: hrishikesh-nalawade <[email protected]>
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Sensitive Sensitive change that requires peer review size/L

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

3 participants