-
Notifications
You must be signed in to change notification settings - Fork 69
fix: Log ignored certificates during client authentication #4415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v3.x.x
Are you sure you want to change the base?
fix: Log ignored certificates during client authentication #4415
Conversation
Signed-off-by: hrishikesh-nalawade <[email protected]>
Signed-off-by: hrishikesh-nalawade <[email protected]>
…ent-certificate-ino
| certificateForClientAuth | ||
| ); | ||
|
|
||
| // Log ignored certificates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the comments needed? The method name is self-explanatory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, will remove most of the comments after after review and before merging.
|
What about microservices' mode CategorizeCertsFilter? Do we want to print it also there? It's still the most used configuration mode and it may be helpful to have more diagnostics there |
|
Does the PR fix #4164 fully? The issue also refers to documentation update |
Thank You for pointing that out, I was not aware of that. I'll implement the changes in CategorizeCertsFilter as well. |
…ld be done in CategorizeCertsFilter and CategorizeCertsWebFilter Signed-off-by: hrishikesh-nalawade <[email protected]>
Signed-off-by: hrishikesh-nalawade <[email protected]>
|



Description
API-Layer filters out its own certificates during client authentication but doesn't log which certificates were ignored, making troubleshooting difficult.
CertificateLoggingUtilsutility class for certificate loggingCategorizeCertsFilterandCategorizeCertsWebFilterLinked to #4164
Type of change
Please delete options that are not relevant.
Checklist: