fix: increase default session timeout to prevent large file transfer failures (closes #392)#402
Open
botbikamordehai2-sketch wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The session timeout was hardcoded to 30 seconds, causing large file uploads/downloads (e.g., SMP/E packages) to fail with a
ConnectionError: ('Connection aborted.', TimeoutError('The write operation timed out'))after approximately 30 seconds.Fix
Increased the default timeout from 30 seconds to 300 seconds (5 minutes) to accommodate large file transfers that require longer to complete. This value can still be overridden by the user if needed.
Closes #392