Added skipping of toggle commands (fix for Grid Optimized)#5
Open
YamikoHikariX wants to merge 2 commits intozxbc:mainfrom
Open
Added skipping of toggle commands (fix for Grid Optimized)#5YamikoHikariX wants to merge 2 commits intozxbc:mainfrom
YamikoHikariX wants to merge 2 commits intozxbc:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toggle commands never require smart activation as far as I understand. This fixes the problem that occurs with Grid Optimized controls, where keybindings for toggle commands revert to working like default toggles (press the keybinding to go through the different states of the toggle) instead of the intended behavior (one tap for ON, two taps for OFF, three taps for yellow state). Might also make the widget a bit more efficient