Skip to content

Conversation

@SENya1990
Copy link
Collaborator

@SENya1990 SENya1990 commented Jan 17, 2026

Changes Overview

Diagnostic

  • Added to PX1098 recognition of accessor methods from base properties and events overridden via PXOverride mechanism
  • Fixed PX1098 code fix to correctly generate XML doc comment for accessor methods from base properties and events
  • Added unit tests for PX1098 diagnostic and code fix for an overridden property
  • Updated unit tests for PX1096 with a scenario with an overridden property

Fixed Acuminator Dependencies

  • Updated MSBuiId locator nuget package in the console runner and fixed issue with a potential redistribution of MSBuild DLLs with the app
  • Updated Roslyn workspace packages in the console runner to recognize code sources using features from the latest version of C#
  • Updated build tools nuget package in VSIX project

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a false alert (ATR-941, DEV-PX1102) related to XML documentation comment validation for PXOverride attributes on property accessors. The fix ensures that when a property getter/setter is marked with [PXOverride], the analyzer correctly validates XML comments that reference the property itself (not the accessor method) and generates appropriate XML documentation.

Changes:

  • Extended analyzer logic to handle property accessors, event accessors, and reduced extension methods when validating XML documentation references
  • Updated package versions for VSSDK.BuildTools and Microsoft.Build/CodeAnalysis dependencies
  • Added comprehensive test coverage for property override scenarios
  • Removed extraneous blank lines from project file

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
Acuminator.Vsix.csproj Updated VSSDK.BuildTools version and removed blank lines
Acuminator.Runner.NetFramework.csproj Updated Microsoft.Build and CodeAnalysis package versions with explicit runtime exclusions
PXOverrideAnalyzer.cs Refactored to map method kinds to appropriate symbol types for documentation ID generation
BaseMethodReferenceInXmlDocComment.cs Added logic to resolve property/event symbols from accessor methods for XML comment validation
PXOverrideWithoutXmlCommentTests.cs Added test cases for property override scenarios and renamed existing test method for clarity
PXOverrideOfPropertyFromBasePXGraphWithoutXmlComment.cs New test source file for property override without XML comment
PXOverrideOfPropertyFromBasePXGraphWithoutXmlComment_Expected.cs Expected test output with XML comment added
PXOverrideOfMethodFromBasePXGraph.cs Added property override test case to existing signature mismatch test

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@SENya1990 SENya1990 changed the title Bugfix/atr 941 dev px1102 false alert Bugfix/atr 941 dev px1098 false alert Jan 17, 2026
@SENya1990 SENya1990 merged commit 958b938 into dev Jan 19, 2026
@SENya1990 SENya1990 deleted the bugfix/ATR-941-dev-PX1102-false-alert branch January 19, 2026 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants