-
Notifications
You must be signed in to change notification settings - Fork 9
Bugfix/atr 941 dev px1098 false alert #653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… warning about MSBuild dlls that should be excluded from the application runtime dependencies
…ecognize the latest C# syntax in the console runner
…n the XML doc comment to the PX1098 diagnostic
…rom the PX1098 diagnostic to fix the generated XML comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a false alert (ATR-941, DEV-PX1102) related to XML documentation comment validation for PXOverride attributes on property accessors. The fix ensures that when a property getter/setter is marked with [PXOverride], the analyzer correctly validates XML comments that reference the property itself (not the accessor method) and generates appropriate XML documentation.
Changes:
- Extended analyzer logic to handle property accessors, event accessors, and reduced extension methods when validating XML documentation references
- Updated package versions for VSSDK.BuildTools and Microsoft.Build/CodeAnalysis dependencies
- Added comprehensive test coverage for property override scenarios
- Removed extraneous blank lines from project file
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| Acuminator.Vsix.csproj | Updated VSSDK.BuildTools version and removed blank lines |
| Acuminator.Runner.NetFramework.csproj | Updated Microsoft.Build and CodeAnalysis package versions with explicit runtime exclusions |
| PXOverrideAnalyzer.cs | Refactored to map method kinds to appropriate symbol types for documentation ID generation |
| BaseMethodReferenceInXmlDocComment.cs | Added logic to resolve property/event symbols from accessor methods for XML comment validation |
| PXOverrideWithoutXmlCommentTests.cs | Added test cases for property override scenarios and renamed existing test method for clarity |
| PXOverrideOfPropertyFromBasePXGraphWithoutXmlComment.cs | New test source file for property override without XML comment |
| PXOverrideOfPropertyFromBasePXGraphWithoutXmlComment_Expected.cs | Expected test output with XML comment added |
| PXOverrideOfMethodFromBasePXGraph.cs | Added property override test case to existing signature mismatch test |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/Acuminator/Acuminator.Analyzers/StaticAnalysis/PXOverride/PXOverrideAnalyzer.cs
Show resolved
Hide resolved
src/Acuminator/Acuminator.Analyzers/StaticAnalysis/PXOverride/PXOverrideAnalyzer.cs
Show resolved
Hide resolved
src/Acuminator/Acuminator.Runner.NetFramework/Acuminator.Runner.NetFramework.csproj
Outdated
Show resolved
Hide resolved
...Acuminator.Analyzers/StaticAnalysis/PXOverride/Helpers/BaseMethodReferenceInXmlDocComment.cs
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
Changes Overview
Diagnostic
PXOverridemechanismFixed Acuminator Dependencies