Update 188 attribute to cover 0 value #551
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I think updating the threshold logic makes more sense than creating a 0,0 bucket. What do you think? |
Author
|
I'll try to find time to rework logic |
Starosdev
added a commit
to Starosdev/scrutiny
that referenced
this pull request
Nov 30, 2025
…0 (upstream PR AnalogJ#551) Adds an observed threshold entry for ATA attribute 188 (Command_Timeout) when the value is exactly 0. This fixes incorrect failure rate calculations for drives with zero command timeouts, particularly affecting Seagate drives. Related to issues with Seagate Command Timeout display (AnalogJ#799). Origin: AnalogJ#551 Original author: @aivus
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
I noticed that in case 188 attribute has value
0it is shown aswarnwith theCould not determine Observed Failure Rate for Critical Attributetooltip.This is happening because comparison logic in smart_ata_attribute.go doesn't include
lowvalue. But in caselow == highbucket will be selected.