Repository navigation
feat(mavftp): Add mavftp reentracy support from ardupilot/pymavlink#1288 - #2192
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new re-entrancy paths lack corresponding regression tests in this repository.
1 open finding
What changed in this PR
Ports upstream MAVFTP re-entrancy hardening into the flight-controller communication backend.
Changes:
- Adds iterative drains for inline replies.
- Guards transfer cleanup and callbacks against operation replacement.
- Hardens upload, download, and CRC state ownership.
| File | Description |
|---|---|
ardupilot_methodic_configurator/backend_mavftp.py |
Adds re-entrant MAVFTP state handling and cleanup guards. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+961
to
+962
| def __send_continuation(self, op: FTP_OP) -> None: | ||
| """Send list and burst continuations without nesting inline replies.""" |
Contributor
☂️ Code Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add mavftp reentracy support from ArduPilot/pymavlink#1288
Checklist
git commit --signoff)Testing
Describe how you tested these changes: