Fix minor bugs in script to update dependencies #6150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EZoni
added
bug
EZoni
force-pushed
the
update_dependencies_bugfix
branch
from
d2ad7b3 to
49713d3
Compare
EZoni
force-pushed
the
update_dependencies_bugfix
branch
from
49713d3 to
dedeca6
Compare
EZoni
changed the title
EZoni
commented
Sep 10, 2025
| tags_response = requests.get(repo_subdict["tags"]) | ||
| tags_list = tags_response.json() | ||
| # filter out old-format tags for specific repositories | ||
| tags_list_filtered = copy.deepcopy(tags_list) |
Member
Author
There was a problem hiding this comment.
Without this fix tags_list_filtered could be used uninitialized.
EZoni
commented
Sep 10, 2025
| print(f"- old commit: {dependencies_data[commit_key]}") | ||
| print(f"- new commit: {new_commit_sha}") | ||
| if dependencies_data[commit_key] == repo_commit_sha: | ||
| if dependencies_data[commit_key] == new_commit_sha: |
Member
Author
There was a problem hiding this comment.
new_commit_sha is the variable that contains the correct information (commit sha or version tag).
ax3l
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a minor bug that I found while testing the same tool in AMReX-Codes/pyamrex#474.