Gate backend prod deploys on blessing#9203
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6c20f0e12e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
2 issues found across 2 files
Confidence score: 1/5
- In
.github/workflows/gcp_backend.yml, the prod blessing check is attached torepair-trafficinstead ofdeploy, so the defaultmode: deploypath can promote to prod without validation; merging as-is creates a direct policy bypass on normal releases — move the blessing gate into thedeployjob (or a shared prerequisite) before merging. - In
.github/scripts/check-backend-prod-promotion-policy.py, thetext.find()-based ordering logic can treat checks in different jobs as if they were in the same sequence, so the guard may report compliant workflows that still bypass enforcement; merging as-is leaves the protection unreliable even after workflow edits — update the parser to validate ordering within the correct job scope and add a failing test for this bypass case before merging.
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
85e8a15 to
a614fb3
Compare
6c20f0e to
70c69a7
Compare
|
Reviewed the outstanding Codex P1 review thread ("Move backend blessing validation into deploy job"). No code change was needed — the thread was left on an earlier diff and is already addressed by the current code on this branch:
Verification run locally against this branch (all passed):
The outdated Codex P1 thread has been resolved. |
kodjima33
left a comment
There was a problem hiding this comment.
Gate backend prod deploys on blessing — approve-only; modifies gcp_backend.yml deploy workflow, needs Nik.
|
Will wait for existing blessing infra to bake first |
|
Closing as superseded by #9399. |
|
Hey @Git-on-my-level 👋 Thank you so much for taking the time to contribute to Omi! We truly appreciate you putting in the effort to submit this pull request. After careful review, we've decided not to merge this particular PR. Please don't take this personally — we genuinely try to merge as many contributions as possible, but sometimes we have to make tough calls based on:
Before your next PR, please skim:
If this was declined for direction or taste, maintainers should cite an invariant ID or open a proposed one — ask if that citation is missing. Your contribution is still valuable to us, and we'd love to see you contribute again in the future! If you'd like feedback on how to improve this PR or want to discuss alternative approaches, please don't hesitate to reach out. Thank you for being part of the Omi community! |
Summary
Stack
Verification