Gate backend prod deploys on python-backend blessing#9399
Open
Git-on-my-level wants to merge 2 commits into
Open
Gate backend prod deploys on python-backend blessing#9399Git-on-my-level wants to merge 2 commits into
Git-on-my-level wants to merge 2 commits into
Conversation
Require a python-backend-bless-<sha> release before prod gcp_backend deploys, with a typed override and a repo-checks policy guard so the gate stays ahead of GCP auth/build/deploy. Deploy identity now uses checked-out HEAD instead of raw GITHUB_SHA. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
Author
|
@cursor address merge conflict |
|
Merge conflict resolved and pushed. Conflict: Resolution: Kept all three hygiene steps: - name: Test python backend blessing gate
run: python3 .github/scripts/test_check_python_backend_blessing.py
- name: Test release blessing helpers
run: python3 .github/scripts/test_release_blessing.py
- name: Test automatic desktop beta candidate gate
run: python3 .github/scripts/test_check_desktop_auto_beta_candidate.pyVerification (all passed):
Pushed:   |
Resolve repo-checks.yml conflict by keeping both the python-backend blessing/release tests and main's automatic desktop beta candidate test. Verification: - python3 .github/scripts/check-backend-prod-promotion-policy.py - python3 .github/scripts/test_check_python_backend_blessing.py - python3 .github/scripts/test_release_blessing.py - python3 .github/scripts/test_check_desktop_auto_beta_candidate.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gcp_backend.ymldeploys on apython-backend-bless-<sha>release viacheck-python-backend-blessing.py, before Google Auth / image build / Cloud Run deployoverride_unblessed+I-ACCEPT-UNBLESSED-PROD-RISK) and compute deploy identity from checked-outgit rev-parse HEADinstead of rawGITHUB_SHA.github/scripts/check-backend-prod-promotion-policy.pyand enforce it (plus existing python blessing unit tests) inrepo-checks.ymlhygieneset -u(same pattern as desktop Clarify desktop release qualification and stable-candidate lifecycle #9380)Supersedes #9203. #9201 (surface registry) and #9202 (bless command + validators) are already on
main; this PR only lands the remaining prod deploy gate + policy guard.Desktop coupling (desktop promotion requiring backend blessing) remains a separate PR — successor to #9204.
Test plan
python3 .github/scripts/check-backend-prod-promotion-policy.py→backend prod promotion policy OKpython3 .github/scripts/test_check_python_backend_blessing.py→ OKpython3 .github/scripts/test_release_blessing.py→ OKBLESSING_CHECK_ARGSis always populated (no emptyOVERRIDE_ARGS=()underset -u)repo-checkshygiene job green on this PRMade with Cursor