provide FileResolverError with filename information - #291
Merged
Conversation
This introduces a new `FileResolverError` type that wraps `io:Error` and includes the `PathBuf` of the file that caused the error.
Bergmann89
approved these changes
Sep 6, 2026
Owner
|
@wsipak Thanks for the contribution. Merged 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds filename information to errors returned by
FileResolver.The current error type is not helpful when files are included recursively. The current error message is:
This PR introduces
FileResolverError, which includes the path of the file that caused the error: