Stream support: Fix for Epeck #9072
Conversation
|
This is related to #7874. There we said:
Here that would mean adding the point map parameter to the named parameters of |
|
And with vertex you mean the index in the range of points. |
|
Yes, here it's the point range's point map (like in Point_set_3 / Point_set_processing_3, etc.) whereas for the other PR, it's a vertex point map |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/9072/v0/Manual/index.html |
… point property map which is implemented
… point property map which is implemented
|
Successfully tested in CGAL-6.2-Ic-20 |
This comment was marked as outdated.
This comment was marked as outdated.
## Summary of Changes As reported in #7868 the function `CGAL::IO::write_PLY()` used in binary mode does not correctly write the coordinates if the points are from a kernel with exact constructions. ~~This PR applies `to_double()" to the coordinates.~~ ~~After a discussion with @MaelRL we decided that the user is in charge to pass a `vertex_point_map` as named parameter that does the conversion. This is straightforward as we offer the [`Cartesian_converter_property_map`](https://doc.cgal.org/latest/Property_map/structCGAL_1_1Cartesian__converter__property__map.html).~~ Moving back to the previous proposal: hardcode some to_double and to_float casts such that we meet the requirements of the file format, whatever the input. As the problem is the same for the vertex normals we add a named parameter `vertex_normal_map`. ### Todo - [x] Fix the generic function `write_polygon_mesh()`. Currently it is fixed for `Surface_mesh` ## Release Management * Affected package(s): Stream_support * Issue(s) solved (if any): fix #7868 and fix #7327 * License and copyright ownership: unchanged * upcoming integration, update #9072 and test it
5 participants
Summary of Changes
For file formats that expect floating point coordinates we convert on the fly so that
CGAL::io::write_polygon_soup()also works for polygon soups withFTwhich are non-float/double, e.g.Exact_predicates_exact_constructions_kernel.Additionally, we document the named parameter
point_mapas it was missing.Release Management