Fixing various UI issues #83877
Merged
Fixing various UI issues #83877
+21
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chaning to a weak_ptr created a lot of errors. Changed it back, and instead pass out the shared_ptr For outer function to control lifetime Fixes CleverRaven#83854 Fixes CleverRaven#83870 Fixes CleverRaven#83873 Fixes CleverRaven#78783 Reverts CleverRaven#83856 Reverts CleverRaven#83832
github-actions
bot
added
Info / User Interface
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
astyled
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Various UI problems caused by shared_ptr change"
Purpose of change
This fixes a bunch of issues caused by my shared_ptr change
Fixes #83854
Fixes #83870
Fixes #83873
and reverts the shared_ptr change
Reverts #83856
Reverts #83832
BUT still fixes the UI bouncing in
Fixes #78783
And scrolling:
Fixes #82428
Describe the solution
I've reverted the shared_ptr change as it affected to many parts of the code.
Now it is just a weak_ptr, but when it is locked it optionally passes out the shared_ptr to the calling function.
This allows the calling function to stop the UI being created over and over if its looping over the query()
Describe alternatives you've considered
Testing
Tested ALL issues that have been posted, and tested the bouncing.
Additional context