Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimal LAI (optimal_lai.jl), after Zhou et al., 2025
TODO:
compute_L_max(equation 11 in paper), Ao is "potential GPP" (annual) = PAR * LUE (assumes fPAR = 1) - this is NOT observed annual GPP. LUE is from P model (equation 2 and 3). Kat question: if we modified LUE to account for moisture stress, do we need the second part of equation 11 (water limitation adjustment of fAPARmax).Note: for initialization, we will need to compute this Ao first and read it...
TODO (call with Kat 11/5):
TO DO:
p.canopy.lai_model.LAI, which means there are two LAIs: the prescribed onep.canopy.biomass.area_index.leaf, and the modeled one. (this is intentional for now - so we can compare them). Maybe we want to do this differently. (and maybe we want to use biomass and not a new lai_model). let's discuss.--> we could start by reading them and have them constant (except daily gpp), and later, store in Y starting year 2?
Ozark, with