-
Notifications
You must be signed in to change notification settings - Fork 255
Lock Exchange Example #4968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Lock Exchange Example #4968
Changes from 1 commit
3f04cfc
2ed3734
cdf7214
f186c86
656387a
b8088c5
1714995
07cc719
86632aa
62131dc
4c4fa5d
37e3107
f75b717
76b5229
bbcefb9
b31a765
966b371
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,63 @@ | ||||||||||||||||||||||||||||||||||||
| using Oceananigans | ||||||||||||||||||||||||||||||||||||
| using Oceananigans.Units | ||||||||||||||||||||||||||||||||||||
| using Oceananigans.Grids: MutableVerticalDiscretization | ||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||
| using Oceananigans.Grids: MutableVerticalDiscretization | |
| using Oceananigans.Grids |
This worked fine for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this at all? What name is missing?
surbhidhiman marked this conversation as resolved.
Show resolved
Hide resolved
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| z_disc = MutableVerticalDiscretization((-50, 0)) | |
| z = MutableVerticalDiscretization((-50, 0)) |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # Allow for mutable surface height | |
| z_disc = MutableVerticalDiscretization((-50, 0)) | |
| # Initialize the grid | |
| underlying_grid = RectilinearGrid( | |
| size = (Nx, Nz), | |
| x = (0, L), | |
| z = z_disc, | |
| topology = (Bounded, Flat, Bounded), | |
| halo = (5, 5) | |
| ) | |
| # Allow for mutable surface height | |
| z = MutableVerticalDiscretization((-50, 0)) | |
| x = (0, L) | |
| # Initialize the grid | |
| underlying_grid = RectilinearGrid(size = (Nx, Nz); halo = (5, 5), x, z, topology = (Bounded, Flat, Bounded)) |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| grid = ImmersedBoundaryGrid(underlying_grid, GridFittedBottom(bottom)) | |
| grid = ImmersedBoundaryGrid(underlying_grid, PartialCellBottom(bottom)) |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| tracers = (:b,), | |
| tracers = :b, |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| closure = (VerticalScalarDiffusivity(ν=1e-4), HorizontalScalarDiffusivity(ν=1.0)), |
I suggest running this as an ILES unless that doesn't work for some reason!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I have removed the closure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this automatically inferred from the grid's z coordinate type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i thought so too. we need to hear from @simone-silvestri on this!
surbhidhiman marked this conversation as resolved.
Show resolved
Hide resolved
surbhidhiman marked this conversation as resolved.
Show resolved
Hide resolved
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example should conclude with a visualization of the results, including some analysis / physical interpretation of what the results show
Uh oh!
There was an error while loading. Please reload this page.