-
Notifications
You must be signed in to change notification settings - Fork 6
Minor cleanup #417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Minor cleanup #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #417 +/- ##
=======================================
Coverage ? 83.45%
Complexity ? 1122
=======================================
Files ? 227
Lines ? 8067
Branches ? 628
=======================================
Hits ? 6732
Misses ? 1003
Partials ? 332
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: [email protected] <[email protected]>
gauravahuja
previously approved these changes
Oct 9, 2025
Filter94
reviewed
Oct 10, 2025
Filter94
reviewed
Oct 10, 2025
Filter94
reviewed
Oct 10, 2025
Filter94
reviewed
Oct 10, 2025
jonesho
reviewed
Oct 10, 2025
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Filter94
previously approved these changes
Oct 21, 2025
fluentcrafter
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some clean up based on review comments from already merged PRs.
Note
Removes SyncStatusProvider from P2P wiring, introduces configurable discovery search interval/timeout, migrates discovery to Teku DiscoveryPeer, and updates related logic/tests.
SyncStatusProviderfromP2PNetworkImpl,MaruPeerManager, factories, and call sites.MaruPeerManager: accept and usep2pConfig; pass discovery config toPeerDiscoveryTask; improvedstop()(disconnects peers) and concise logging.P2PNetworkImpl.stop(): simplify by delegating and awaiting only libp2p stop.MaruRpcResponseCallback: lower log level totracewhen RPC stream is already closed.P2PConfig.Discovery.searchIntervalandsearchTimeout(with defaults); parse and propagate in tests.PeerDiscoveryTask: use discovery config for schedule/timeout; switch to TekuDiscoveryPeer.MaruDiscoveryService: return/consumeDiscoveryPeer; adjust node record listener; block on start; dropMaruDiscoveryPeerclass.MaruAppFactoryand test factories/CLI to newp2pNetworkFactorysignature (no sync provider argument).HopliteFriendlinessTest.Written by Cursor Bugbot for commit d7656ad. This will update automatically on new commits. Configure here.