Skip to content

Fix CleanObjFiles job #7648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 17, 2025
Merged

Fix CleanObjFiles job #7648

merged 7 commits into from
Oct 17, 2025
+2 −1

Conversation

@NachoEchevarria
Copy link
Collaborator

@NachoEchevarria NachoEchevarria commented Oct 13, 2025 •
edited
Loading

Summary of changes

In some pipeline runs (here or here), we are getting the following error:

Starting: Run 'CleanObjFiles' in Docker
==============================================================================
Task         : Command line
Description  : Run a command line script using Bash on Linux and macOS and cmd.exe on Windows
Version      : 2.250.1
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/command-line
==============================================================================
Generating script.
========================== Starting Command Output ===========================
/usr/bin/bash --noprofile --norc /mnt/vss/_work/_temp/091f2bee-2a9e-456c-a12e-fd0574d2a12e.sh
Using SDK version 10.0.100-rc.1.25451.107
/mnt/vss/_work/_temp/091f2bee-2a9e-456c-a12e-fd0574d2a12e.sh: line 9: TestAllPackageVersions: command not found
/mnt/vss/_work/_temp/091f2bee-2a9e-456c-a12e-fd0574d2a12e.sh: line 9: IncludeMinorPackageVersions: command not found
docker: Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: unable to apply cgroup configuration: unable to start unit "docker-38cc23ebfc71d2d7f6f4df0fe154251ca6aab0ce223dfcf56c3a4ed35da88086.scope" (properties [{Name:Description Value:"libcontainer container 38cc23ebfc71d2d7f6f4df0fe154251ca6aab0ce223dfcf56c3a4ed35da88086"} {Name:Slice Value:"system.slice"} {Name:Delegate Value:true} {Name:PIDs Value:@au [11499]} {Name:MemoryAccounting Value:true} {Name:CPUAccounting Value:true} {Name:IOAccounting Value:true} {Name:TasksAccounting Value:true} {Name:DefaultDependencies Value:false}]): Message recipient disconnected from message bus without replying: unknown

Run 'docker run --help' for more information

##[error]Bash exited with code '125'.
Finishing: Run 'CleanObjFiles' in Docker

In order to fix this error, Call sites can set retryCountForRunCommand: 3 for steps sensitive to the occasional OCI runtime create failed / Message recipient disconnected from message bus error.

Reason for change

Implementation details

Test coverage

Other details

@github-actions github-actions bot added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Oct 13, 2025
@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Oct 13, 2025 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7648) - mean (74ms)  : 73, 76
     .   : milestone, 74,
    master - mean (72ms)  : 71, 73
     .   : milestone, 72,

    section Baseline
    This PR (7648) - mean (71ms)  : 68, 73
     .   : milestone, 71,
    master - mean (68ms)  : 65, 70
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (7648) - mean (1,078ms)  : 1005, 1151
     .   : milestone, 1078,
    master - mean (1,046ms)  : 1008, 1084
     .   : milestone, 1046,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7648) - mean (113ms)  : crit, 107, 120
     .   : crit, milestone, 113,
    master - mean (106ms)  : 105, 107
     .   : milestone, 106,

    section Baseline
    This PR (7648) - mean (109ms)  : 105, 112
     .   : milestone, 109,
    master - mean (105ms)  : 103, 108
     .   : milestone, 105,

    section CallTarget+Inlining+NGEN
    This PR (7648) - mean (759ms)  : 728, 790
     .   : milestone, 759,
    master - mean (744ms)  : 719, 769
     .   : milestone, 744,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7648) - mean (98ms)  : 95, 100
     .   : milestone, 98,
    master - mean (101ms)  : 100, 102
     .   : milestone, 101,

    section Baseline
    This PR (7648) - mean (97ms)  : 95, 100
     .   : milestone, 97,
    master - mean (100ms)  : 97, 102
     .   : milestone, 100,

    section CallTarget+Inlining+NGEN
    This PR (7648) - mean (734ms)  : 686, 782
     .   : milestone, 734,
    master - mean (776ms)  : 729, 824
     .   : milestone, 776,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7648) - mean (100ms)  : crit, 95, 105
     .   : crit, milestone, 100,
    master - mean (93ms)  : 91, 95
     .   : milestone, 93,

    section Baseline
    This PR (7648) - mean (100ms)  : 92, 108
     .   : milestone, 100,
    master - mean (92ms)  : 89, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (7648) - mean (676ms)  : 653, 699
     .   : milestone, 676,
    master - mean (661ms)  : 648, 674
     .   : milestone, 661,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7648) - mean (199ms)  : 194, 204
     .   : milestone, 199,
    master - mean (195ms)  : 193, 198
     .   : milestone, 195,

    section Baseline
    This PR (7648) - mean (194ms)  : 189, 198
     .   : milestone, 194,
    master - mean (192ms)  : 188, 195
     .   : milestone, 192,

    section CallTarget+Inlining+NGEN
    This PR (7648) - mean (1,178ms)  : 1122, 1233
     .   : milestone, 1178,
    master - mean (1,163ms)  : 1108, 1218
     .   : milestone, 1163,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7648) - mean (280ms)  : 275, 285
     .   : milestone, 280,
    master - mean (276ms)  : 272, 280
     .   : milestone, 276,

    section Baseline
    This PR (7648) - mean (278ms)  : 272, 284
     .   : milestone, 278,
    master - mean (277ms)  : 269, 284
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (7648) - mean (955ms)  : 913, 996
     .   : milestone, 955,
    master - mean (946ms)  : 909, 984
     .   : milestone, 946,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7648) - mean (271ms)  : 267, 276
     .   : milestone, 271,
    master - mean (280ms)  : 275, 285
     .   : milestone, 280,

    section Baseline
    This PR (7648) - mean (271ms)  : 266, 277
     .   : milestone, 271,
    master - mean (279ms)  : 275, 283
     .   : milestone, 279,

    section CallTarget+Inlining+NGEN
    This PR (7648) - mean (941ms)  : 882, 1000
     .   : milestone, 941,
    master - mean (996ms)  : 953, 1040
     .   : milestone, 996,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7648) - mean (270ms)  : 267, 274
     .   : milestone, 270,
    master - mean (268ms)  : 263, 272
     .   : milestone, 268,

    section Baseline
    This PR (7648) - mean (271ms)  : 265, 276
     .   : milestone, 271,
    master - mean (267ms)  : 264, 271
     .   : milestone, 267,

    section CallTarget+Inlining+NGEN
    This PR (7648) - mean (858ms)  : 836, 880
     .   : milestone, 858,
    master - mean (857ms)  : 835, 880
     .   : milestone, 857,
Loading

@pr-commenter
Copy link

pr-commenter bot commented Oct 15, 2025 •
edited
Loading

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7648 compared to master:

  • 3 benchmarks are slower, with geometric mean 1.455
  • 7 benchmarks have fewer allocations
  • 4 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7648

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑netcoreapp3.1 5.74 KB 5.7 KB -45 B -0.78%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 10.9μs 58.4ns 330ns 0 0 0 5.53 KB
master StartStopWithChild netcoreapp3.1 14.8μs 71.5ns 286ns 0 0 0 5.74 KB
master StartStopWithChild net472 21.9μs 109ns 511ns 0.958 0.426 0.106 6 KB
#7648 StartStopWithChild net6.0 10.6μs 57.7ns 346ns 0 0 0 5.51 KB
#7648 StartStopWithChild netcoreapp3.1 13.8μs 65.7ns 254ns 0 0 0 5.7 KB
#7648 StartStopWithChild net472 22.9μs 120ns 613ns 1.06 0.317 0.106 6.01 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 943μs 144ns 558ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.03ms 45.9ns 172ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.19ms 82.2ns 318ns 0 0 0 3.31 KB
#7648 WriteAndFlushEnrichedTraces net6.0 933μs 148ns 554ns 0 0 0 2.71 KB
#7648 WriteAndFlushEnrichedTraces netcoreapp3.1 1.03ms 122ns 421ns 0 0 0 2.7 KB
#7648 WriteAndFlushEnrichedTraces net472 1.19ms 87.6ns 328ns 0 0 0 3.31 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 355μs 1.84μs 8.63μs 0 0 0 180.01 KB
master AllCycleSimpleBody netcoreapp3.1 523μs 1.68μs 7.7μs 0 0 0 185.8 KB
master AllCycleSimpleBody net472 469μs 157ns 607ns 32.4 0 0 206.3 KB
master AllCycleMoreComplexBody net6.0 367μs 1.23μs 4.78μs 0 0 0 183.53 KB
master AllCycleMoreComplexBody netcoreapp3.1 552μs 636ns 2.46μs 0 0 0 189.23 KB
master AllCycleMoreComplexBody net472 480μs 74.7ns 269ns 31.2 0 0 209.83 KB
master ObjectExtractorSimpleBody net6.0 330ns 1.62ns 7.08ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 401ns 1.97ns 8.57ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 296ns 0.0313ns 0.117ns 0.0432 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.24μs 33.6ns 121ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.82μs 39.5ns 185ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.68μs 3.02ns 11.7ns 0.6 0 0 3.8 KB
#7648 AllCycleSimpleBody net6.0 354μs 1.78μs 7.98μs 0 0 0 180.01 KB
#7648 AllCycleSimpleBody netcoreapp3.1 503μs 1.79μs 6.46μs 0 0 0 185.8 KB
#7648 AllCycleSimpleBody net472 469μs 200ns 774ns 32.4 0 0 206.3 KB
#7648 AllCycleMoreComplexBody net6.0 366μs 403ns 1.45μs 0 0 0 183.53 KB
#7648 AllCycleMoreComplexBody netcoreapp3.1 529μs 1.87μs 6.76μs 0 0 0 189.23 KB
#7648 AllCycleMoreComplexBody net472 481μs 146ns 566ns 32.4 0 0 209.83 KB
#7648 ObjectExtractorSimpleBody net6.0 322ns 1.65ns 7.39ns 0 0 0 280 B
#7648 ObjectExtractorSimpleBody netcoreapp3.1 400ns 2.12ns 11.2ns 0 0 0 272 B
#7648 ObjectExtractorSimpleBody net472 302ns 0.0286ns 0.111ns 0.0439 0 0 281 B
#7648 ObjectExtractorMoreComplexBody net6.0 6.18μs 34.1ns 199ns 0 0 0 3.78 KB
#7648 ObjectExtractorMoreComplexBody netcoreapp3.1 7.63μs 38.4ns 172ns 0 0 0 3.69 KB
#7648 ObjectExtractorMoreComplexBody net472 6.73μs 0.776ns 2.9ns 0.572 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 76.6μs 209ns 808ns 0 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 96.1μs 327ns 1.27μs 0 0 0 32.4 KB
master EncodeArgs net472 109μs 14.2ns 55.1ns 4.93 0 0 32.5 KB
master EncodeLegacyArgs net6.0 146μs 36.9ns 138ns 0 0 0 2.15 KB
master EncodeLegacyArgs netcoreapp3.1 196μs 172ns 666ns 0 0 0 2.15 KB
master EncodeLegacyArgs net472 262μs 23.9ns 89.4ns 0 0 0 2.16 KB
#7648 EncodeArgs net6.0 77.8μs 27.1ns 101ns 0 0 0 32.4 KB
#7648 EncodeArgs netcoreapp3.1 96.6μs 145ns 561ns 0 0 0 32.4 KB
#7648 EncodeArgs net472 110μs 11.7ns 45.2ns 4.94 0 0 32.5 KB
#7648 EncodeLegacyArgs net6.0 146μs 53.5ns 207ns 0 0 0 2.15 KB
#7648 EncodeLegacyArgs netcoreapp3.1 199μs 141ns 526ns 0 0 0 2.14 KB
#7648 EncodeLegacyArgs net472 263μs 40.2ns 156ns 0 0 0 2.16 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Slower ⚠️ Fewer allocations 🎉

Slower ⚠️ in #7648

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack‑netcoreapp3.1 2.390 300,639.79 718,490.09

Fewer allocations 🎉 in #7648

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack‑net472 2.3 KB 2.29 KB -19 B -0.82%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 405μs 45.1ns 175ns 0 0 0 4.55 KB
master RunWafRealisticBenchmark netcoreapp3.1 845μs 7.21μs 71.4μs 0 0 0 4.48 KB
master RunWafRealisticBenchmark net472 429μs 45.4ns 176ns 0 0 0 4.66 KB
master RunWafRealisticBenchmarkWithAttack net6.0 288μs 34.7ns 125ns 0 0 0 2.24 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 301μs 45.7ns 177ns 0 0 0 2.22 KB
master RunWafRealisticBenchmarkWithAttack net472 312μs 35.2ns 136ns 0 0 0 2.3 KB
#7648 RunWafRealisticBenchmark net6.0 392μs 84.9ns 329ns 0 0 0 4.55 KB
#7648 RunWafRealisticBenchmark netcoreapp3.1 831μs 10.3μs 94.1μs 0 0 0 4.48 KB
#7648 RunWafRealisticBenchmark net472 427μs 59.4ns 230ns 0 0 0 4.66 KB
#7648 RunWafRealisticBenchmarkWithAttack net6.0 289μs 82.4ns 297ns 0 0 0 2.24 KB
#7648 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 717μs 1.72μs 6.64μs 0 0 0 2.22 KB
#7648 RunWafRealisticBenchmarkWithAttack net472 309μs 20.2ns 75.6ns 0 0 0 2.29 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 61.2μs 97.1ns 388ns 0 0 0 14.52 KB
master SendRequest netcoreapp3.1 71.3μs 72.5ns 271ns 0 0 0 17.42 KB
master SendRequest net472 0.000824ns 0.000615ns 0.00238ns 0 0 0 0 b
#7648 SendRequest net6.0 61.9μs 117ns 437ns 0 0 0 14.52 KB
#7648 SendRequest netcoreapp3.1 71.7μs 57.5ns 223ns 0 0 0 17.42 KB
#7648 SendRequest net472 0.00112ns 0.000687ns 0.00266ns 0 0 0 0 b
Benchmarks.Trace.CharSliceBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #7648

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0 1.140 799,483.17 911,087.26

More allocations ⚠️ in #7648

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0 3 B 4 B 1 B 33.33%
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net472 73 B 85 B 12 B 16.44%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master OriginalCharSlice net6.0 1.94ms 462ns 1.67μs 0 0 0 640.01 KB
master OriginalCharSlice netcoreapp3.1 2.12ms 919ns 3.18μs 0 0 0 640 KB
master OriginalCharSlice net472 2.66ms 403ns 1.51μs 100 0 0 641.95 KB
master OptimizedCharSlice net6.0 1.34ms 469ns 1.82μs 0 0 0 4 B
master OptimizedCharSlice netcoreapp3.1 1.68ms 794ns 2.97μs 0 0 0 1 B
master OptimizedCharSlice net472 1.96ms 303ns 1.17μs 0 0 0 73 B
master OptimizedCharSliceWithPool net6.0 799μs 66.6ns 258ns 0 0 0 3 B
master OptimizedCharSliceWithPool netcoreapp3.1 828μs 94.8ns 367ns 0 0 0 1 B
master OptimizedCharSliceWithPool net472 1.15ms 98.4ns 381ns 0 0 0 47 B
#7648 OriginalCharSlice net6.0 1.93ms 265ns 955ns 0 0 0 640.01 KB
#7648 OriginalCharSlice netcoreapp3.1 2.14ms 3.57μs 12.9μs 0 0 0 640 KB
#7648 OriginalCharSlice net472 2.64ms 351ns 1.27μs 100 0 0 641.95 KB
#7648 OptimizedCharSlice net6.0 1.42ms 477ns 1.85μs 0 0 0 4 B
#7648 OptimizedCharSlice netcoreapp3.1 1.7ms 1.12μs 4.34μs 0 0 0 1 B
#7648 OptimizedCharSlice net472 2.09ms 490ns 1.9μs 0 0 0 85 B
#7648 OptimizedCharSliceWithPool net6.0 911μs 87.9ns 329ns 0 0 0 4 B
#7648 OptimizedCharSliceWithPool netcoreapp3.1 812μs 100ns 362ns 0 0 0 1 B
#7648 OptimizedCharSliceWithPool net472 1.15ms 144ns 556ns 0 0 0 47 B
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #7648

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 1.130 876,889.79 991,123.21

More allocations ⚠️ in #7648

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 42.04 KB 42.57 KB 530 B 1.26%

Fewer allocations 🎉 in #7648

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 56.63 KB 56.16 KB -467 B -0.82%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 671μs 2.44μs 9.44μs 0 0 0 42.04 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 726μs 1.26μs 4.54μs 0 0 0 41.86 KB
master WriteAndFlushEnrichedTraces net472 878μs 3.99μs 14.9μs 8.33 0 0 56.63 KB
#7648 WriteAndFlushEnrichedTraces net6.0 680μs 1.46μs 5.67μs 0 0 0 42.57 KB
#7648 WriteAndFlushEnrichedTraces netcoreapp3.1 725μs 5.22μs 52.2μs 0 0 0 41.99 KB
#7648 WriteAndFlushEnrichedTraces net472 992μs 4.43μs 17.1μs 4.46 0 0 56.16 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.93μs 1.41ns 5.47ns 0 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 2.54μs 5.69ns 22ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.79μs 3.37ns 12.2ns 0.153 0.0139 0 987 B
#7648 ExecuteNonQuery net6.0 1.9μs 4.92ns 19ns 0 0 0 1.02 KB
#7648 ExecuteNonQuery netcoreapp3.1 2.65μs 12.9ns 51.6ns 0 0 0 1.02 KB
#7648 ExecuteNonQuery net472 2.85μs 3.56ns 13.3ns 0.156 0.0141 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.83μs 0.913ns 3.42ns 0 0 0 1.03 KB
master CallElasticsearch netcoreapp3.1 2.3μs 11.7ns 53.5ns 0 0 0 1.03 KB
master CallElasticsearch net472 3.63μs 5.43ns 21ns 0.163 0 0 1.04 KB
master CallElasticsearchAsync net6.0 1.97μs 9.43ns 40ns 0 0 0 1.01 KB
master CallElasticsearchAsync netcoreapp3.1 2.42μs 9.88ns 38.3ns 0 0 0 1.08 KB
master CallElasticsearchAsync net472 3.89μs 4.99ns 18.7ns 0.155 0 0 1.1 KB
#7648 CallElasticsearch net6.0 1.84μs 8.58ns 32.1ns 0 0 0 1.03 KB
#7648 CallElasticsearch netcoreapp3.1 2.34μs 7.18ns 26.9ns 0 0 0 1.03 KB
#7648 CallElasticsearch net472 3.59μs 5.81ns 22.5ns 0.161 0 0 1.04 KB
#7648 CallElasticsearchAsync net6.0 1.88μs 9.02ns 38.2ns 0 0 0 1.01 KB
#7648 CallElasticsearchAsync netcoreapp3.1 2.4μs 11.5ns 45.9ns 0 0 0 1.08 KB
#7648 CallElasticsearchAsync net472 3.67μs 5.07ns 19.6ns 0.165 0 0 1.1 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.92μs 8.88ns 35.5ns 0 0 0 952 B
master ExecuteAsync netcoreapp3.1 2.35μs 3.63ns 13.6ns 0 0 0 952 B
master ExecuteAsync net472 2.6μs 3.82ns 14.8ns 0.142 0 0 915 B
#7648 ExecuteAsync net6.0 1.86μs 9.33ns 42.7ns 0 0 0 952 B
#7648 ExecuteAsync netcoreapp3.1 2.34μs 6.2ns 24ns 0 0 0 952 B
#7648 ExecuteAsync net472 2.59μs 1.61ns 6.02ns 0.143 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 6.87μs 6.27ns 24.3ns 0 0 0 2.36 KB
master SendAsync netcoreapp3.1 8.5μs 19.2ns 74.3ns 0 0 0 2.9 KB
master SendAsync net472 12.7μs 10ns 37.5ns 0.444 0 0 3.18 KB
#7648 SendAsync net6.0 6.94μs 23.9ns 92.7ns 0 0 0 2.36 KB
#7648 SendAsync netcoreapp3.1 8.49μs 9.92ns 35.8ns 0 0 0 2.9 KB
#7648 SendAsync net472 12.7μs 14.1ns 54.4ns 0.445 0 0 3.18 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7648

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 259.93 KB 273.34 KB 13.42 KB 5.16%

Fewer allocations 🎉 in #7648

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 43.28 KB 42.86 KB -416 B -0.96%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 279.94 KB 272.95 KB -6.98 KB -2.49%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 46.09 KB 43.78 KB -2.31 KB -5.02%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 65.54 KB 57.34 KB -8.19 KB -12.50%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 45μs 244ns 1.86μs 0 0 0 46.09 KB
master StringConcatBenchmark netcoreapp3.1 51μs 271ns 1.84μs 0 0 0 43.28 KB
master StringConcatBenchmark net472 56.2μs 239ns 893ns 0 0 0 65.54 KB
master StringConcatAspectBenchmark net6.0 462μs 1.42μs 4.92μs 0 0 0 259.93 KB
master StringConcatAspectBenchmark netcoreapp3.1 542μs 1.79μs 6.68μs 0 0 0 279.94 KB
master StringConcatAspectBenchmark net472 406μs 2.33μs 17.8μs 0 0 0 278.53 KB
#7648 StringConcatBenchmark net6.0 42.2μs 227ns 1.14μs 0 0 0 43.78 KB
#7648 StringConcatBenchmark netcoreapp3.1 51μs 327ns 3.15μs 0 0 0 42.86 KB
#7648 StringConcatBenchmark net472 57.7μs 264ns 987ns 0 0 0 57.34 KB
#7648 StringConcatAspectBenchmark net6.0 460μs 2.06μs 7.71μs 0 0 0 273.34 KB
#7648 StringConcatAspectBenchmark netcoreapp3.1 515μs 2.51μs 10.3μs 0 0 0 272.95 KB
#7648 StringConcatAspectBenchmark net472 403μs 2.29μs 17μs 0 0 0 278.53 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.63μs 7.61ns 28.5ns 0 0 0 1.7 KB
master EnrichedLog netcoreapp3.1 3.61μs 4.24ns 16.4ns 0 0 0 1.7 KB
master EnrichedLog net472 3.75μs 3.22ns 12.5ns 0.243 0 0 1.64 KB
#7648 EnrichedLog net6.0 2.5μs 14.2ns 86.1ns 0 0 0 1.7 KB
#7648 EnrichedLog netcoreapp3.1 3.61μs 2.55ns 9.88ns 0 0 0 1.7 KB
#7648 EnrichedLog net472 3.72μs 2.91ns 11.3ns 0.242 0 0 1.64 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 123μs 31.2ns 117ns 0 0 0 4.31 KB
master EnrichedLog netcoreapp3.1 127μs 133ns 480ns 0 0 0 4.31 KB
master EnrichedLog net472 167μs 47.7ns 178ns 0 0 0 4.52 KB
#7648 EnrichedLog net6.0 123μs 225ns 842ns 0 0 0 4.31 KB
#7648 EnrichedLog netcoreapp3.1 128μs 293ns 1.09μs 0 0 0 4.31 KB
#7648 EnrichedLog net472 167μs 39.1ns 141ns 0 0 0 4.52 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.94μs 24.6ns 116ns 0 0 0 2.26 KB
master EnrichedLog netcoreapp3.1 6.74μs 20ns 77.5ns 0 0 0 2.26 KB
master EnrichedLog net472 7.35μs 7.72ns 29.9ns 0.294 0 0 2.08 KB
#7648 EnrichedLog net6.0 4.92μs 19.9ns 77.2ns 0 0 0 2.26 KB
#7648 EnrichedLog netcoreapp3.1 6.63μs 23.6ns 91.3ns 0 0 0 2.26 KB
#7648 EnrichedLog net472 7.41μs 5.81ns 22.5ns 0.295 0 0 2.08 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.96μs 10.5ns 57.8ns 0 0 0 1.2 KB
master SendReceive netcoreapp3.1 2.63μs 12ns 45ns 0 0 0 1.2 KB
master SendReceive net472 3.17μs 2.85ns 11ns 0.189 0 0 1.2 KB
#7648 SendReceive net6.0 2.01μs 9.06ns 35.1ns 0 0 0 1.2 KB
#7648 SendReceive netcoreapp3.1 2.58μs 12.8ns 58.6ns 0 0 0 1.2 KB
#7648 SendReceive net472 3.23μs 5.71ns 22.1ns 0.177 0 0 1.2 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.27μs 14.5ns 56.2ns 0 0 0 1.58 KB
master EnrichedLog netcoreapp3.1 5.72μs 7.47ns 28ns 0 0 0 1.63 KB
master EnrichedLog net472 6.44μs 3.42ns 13.2ns 0.291 0 0 2.03 KB
#7648 EnrichedLog net6.0 4.2μs 15.7ns 60.9ns 0 0 0 1.58 KB
#7648 EnrichedLog netcoreapp3.1 5.83μs 9.51ns 35.6ns 0 0 0 1.63 KB
#7648 EnrichedLog net472 6.59μs 7.55ns 27.2ns 0.298 0 0 2.03 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 767ns 0.551ns 2.13ns 0 0 0 576 B
master StartFinishSpan netcoreapp3.1 964ns 4.96ns 23.3ns 0 0 0 576 B
master StartFinishSpan net472 905ns 0.375ns 1.4ns 0.0905 0 0 578 B
master StartFinishScope net6.0 909ns 4.68ns 23ns 0 0 0 696 B
master StartFinishScope netcoreapp3.1 1.18μs 5.81ns 23.2ns 0 0 0 696 B
master StartFinishScope net472 1.13μs 0.0482ns 0.174ns 0.102 0 0 658 B
#7648 StartFinishSpan net6.0 770ns 0.545ns 2.11ns 0 0 0 576 B
#7648 StartFinishSpan netcoreapp3.1 938ns 4.97ns 26.3ns 0 0 0 576 B
#7648 StartFinishSpan net472 908ns 0.412ns 1.54ns 0.0908 0 0 578 B
#7648 StartFinishScope net6.0 919ns 0.558ns 2.16ns 0 0 0 696 B
#7648 StartFinishScope netcoreapp3.1 1.17μs 6.17ns 30.2ns 0 0 0 696 B
#7648 StartFinishScope net472 1.11μs 0.663ns 2.57ns 0.1 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.03μs 5.67ns 34.9ns 0 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 1.4μs 6.93ns 31ns 0 0 0 696 B
master RunOnMethodBegin net472 1.41μs 0.647ns 2.42ns 0.101 0 0 658 B
#7648 RunOnMethodBegin net6.0 1.05μs 5.1ns 20.4ns 0 0 0 696 B
#7648 RunOnMethodBegin netcoreapp3.1 1.38μs 7.28ns 38.5ns 0 0 0 696 B
#7648 RunOnMethodBegin net472 1.42μs 0.575ns 2.23ns 0.101 0 0 658 B

@datadog-datadog-prod-us1

This comment has been minimized.

Sign in to view
@NachoEchevarria NachoEchevarria marked this pull request as ready for review October 17, 2025 12:10
@NachoEchevarria NachoEchevarria requested review from a team as code owners October 17, 2025 12:10
@NachoEchevarria NachoEchevarria merged commit ad0a291 into master Oct 17, 2025
152 of 154 checks passed
@NachoEchevarria NachoEchevarria deleted the nacho/FixCleanObjFiles branch October 17, 2025 13:15
@github-actions github-actions bot added this to the vNext-v3 milestone Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bouwkast bouwkast bouwkast approved these changes

Assignees

No one assigned

Labels

area:builds project files, build scripts, pipelines, versioning, releases, packages

Projects

None yet

Milestone

3.29.0

Development

Successfully merging this pull request may close these issues.

3 participants

@NachoEchevarria @bouwkast