Repository navigation
Conversation
added 2 commits
October 16, 2026 13:35
… false in Highs.h; added standard-form-empty-lp to test standard_form_valid_ assignment
…ail on unit_tests info-md; using uint64_t total in TestHighsParallel loseTime() which was overflowwing. Now UBSAN_OPTIONS=print_stacktrace=1 build/bin/unit_tests passes
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## latest #3430 +/- ##
=======================================
Coverage 75.19% 75.19%
=======================================
Files 460 460
Lines 112413 112421 +8
Branches 17825 17826 +1
=======================================
+ Hits 84532 84540 +8
Misses 27599 27599
Partials 282 282 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As prompted in #3419, now assigning
packFlag = falseinHVectorBase.hSimilar issues also fixed
standard_form_valid_ = falseinHighs.hHighsInfo::valid = false, which causedvalgrindto fail onunit_tests info-md: I wonder why the CI valgrind test didn't fail...uint64_t totalinTestHighsParallel loseTime()which was overflowwingNow
UBSAN_OPTIONS=print_stacktrace=1 build/bin/unit_tests passesChecklist
latestbranchRelated issue
Closes #3419