Fix 3419 and other similar issues

check/TestHighsParallel.cpp

@@ -457,7 +457,9 @@ TEST_CASE("ParallelSchedulerIsPerThread", "[parallel]") {
   REQUIRE(b.threads_after_reset == num_threads_B);
   REQUIRE(b.sum_after_reset == expected_sum);
 
+  HighsTaskExecutor::shutdown(true);
+
   // A really was reset
   REQUIRE(a.threads_after_reset == num_threads_A_second);
   REQUIRE(a.sum_after_reset == expected_sum);
-}
+}

check/TestLpSolvers.cpp

@@ -248,8 +248,8 @@ void testStandardForm(const HighsLp& lp) {
   Highs highs;
   highs.setOptionValue("output_flag", dev_run);
   HighsInt sense = HighsInt(lp.sense_);
-  highs.passModel(lp);
-  highs.run();
+  REQUIRE(highs.passModel(lp) == HighsStatus::kOk);
+  REQUIRE(highs.run() == HighsStatus::kOk);
   //  highs.writeSolution("", kSolutionStylePretty);
   double required_objective_function_value =
       highs.getInfo().objective_function_value;
@@ -366,6 +366,23 @@ TEST_CASE("standard-form-lp", "[highs_lp_solver]") {
   highs.resetThreadScheduler(true);
 }
 
+TEST_CASE("standard-form-empty-lp", "[highs_lp_solver]") {
+  // Exposed that standard_form_valid_ was not initialised if a model
+  // had not been loaded - ie empty or built
+  Highs h;
+  h.setOptionValue("output_flag", dev_run);
+
+  HighsInt num_col;
+  HighsInt num_row;
+  HighsInt num_nz;
+  double offset;
+  REQUIRE(h.getStandardFormLp(num_col, num_row, num_nz, offset) ==
+          HighsStatus::kOk);
+  REQUIRE(num_col == 0);
+  REQUIRE(num_row == 0);
+  REQUIRE(num_nz == 0);
+}
+
 TEST_CASE("simplex-stats", "[highs_lp_solver]") {
   Highs h;
   const HighsSimplexStats& simplex_stats = h.getSimplexStats();

highs/Highs.h

@@ -1649,7 +1649,7 @@ class Highs {
       HighsPresolveStatus::kNotPresolved;
   HighsModelStatus model_status_ = HighsModelStatus::kNotset;
 
-  bool standard_form_valid_;
+  bool standard_form_valid_ = false;
   double standard_form_offset_;
   std::vector<double> standard_form_cost_;
   std::vector<double> standard_form_rhs_;

highs/lp_data/HighsInfo.h

@@ -93,7 +93,7 @@ class InfoRecordDouble : public InfoRecord {
 // todo: when creating the new info don't forget underscores for class
 // variables but no underscores for struct
 struct HighsInfoStruct {
-  bool valid;
+  bool valid = false;
   int64_t mip_node_count;
   HighsInt simplex_iteration_count;
   HighsInt ipm_iteration_count;

highs/util/HVectorBase.h

@@ -68,7 +68,7 @@ class HVectorBase {
    */
   void reIndex();
 
-  bool packFlag;               //!< Flag to indicate whether to pack or not
+  bool packFlag = false;       //!< Flag to indicate whether to pack or not
   HighsInt packCount;          //!< Number of nonzeros packed
   vector<HighsInt> packIndex;  //!< Packed indices
   vector<Real> packValue;      //!< Packed values