New Crowdin updates#6003
Open
paullinator wants to merge 13 commits intodevelopfrom
Open
Conversation
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Autofix Details
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Translated strings replaced with English, removing FIO/ENS mentions
- Restored the localized scan address modal titles to include FIO and ENS and removed the unused untranslated parameterized key from affected locale files.
Or push these changes by commenting:
@cursor push bca46e6db9
Preview (bca46e6db9)
diff --git a/src/locales/strings/de.json b/src/locales/strings/de.json
--- a/src/locales/strings/de.json
+++ b/src/locales/strings/de.json
@@ -1086,8 +1086,7 @@
"personalize_wallet_title": "Personalize Your Wallet",
"get_started_button": "Get Started",
"not_now_button": "Not Now",
- "scan_address_modal_title": "Enter Recipient Public Address",
- "scan_address_modal_title_1s": "Enter Recipient %1$s or Public Address",
+ "scan_address_modal_title": "Empfänger FIO, ENS oder öffentliche Adresse eingeben",
"enter_any_title": "Enter any of the following:",
"enter_any_body": "1. Public address to send money to\n2. Private key to sweep\n3. Wallet Connect URI to connect to a dApp\n4. Edge Login URI to login to another device\n\nEdge will auto-detect the URI format and allow you to select an appropriate wallet",
"enter_any_input_hint": "Enter any of the above",
diff --git a/src/locales/strings/es.json b/src/locales/strings/es.json
--- a/src/locales/strings/es.json
+++ b/src/locales/strings/es.json
@@ -1086,8 +1086,7 @@
"personalize_wallet_title": "Personalize Your Wallet",
"get_started_button": "Get Started",
"not_now_button": "Not Now",
- "scan_address_modal_title": "Enter Recipient Public Address",
- "scan_address_modal_title_1s": "Enter Recipient %1$s or Public Address",
+ "scan_address_modal_title": "Introduce el destinatario FIO, ENS, o dirección pública",
"enter_any_title": "Enter any of the following:",
"enter_any_body": "1. Public address to send money to\n2. Private key to sweep\n3. Wallet Connect URI to connect to a dApp\n4. Edge Login URI to login to another device\n\nEdge will auto-detect the URI format and allow you to select an appropriate wallet",
"enter_any_input_hint": "Enter any of the above",
diff --git a/src/locales/strings/esMX.json b/src/locales/strings/esMX.json
--- a/src/locales/strings/esMX.json
+++ b/src/locales/strings/esMX.json
@@ -1086,8 +1086,7 @@
"personalize_wallet_title": "Personaliza tu billetera",
"get_started_button": "Comenzar",
"not_now_button": "Ahora no",
- "scan_address_modal_title": "Enter Recipient Public Address",
- "scan_address_modal_title_1s": "Enter Recipient %1$s or Public Address",
+ "scan_address_modal_title": "Introduce el destinatario FIO, ENS, o dirección pública",
"enter_any_title": "Ingresa cualquiera de los siguientes:",
"enter_any_body": "1. Dirección pública para enviar dinero\n2. Clave privada para barrer fondos\n3. URI de Wallet Connect para conectar con una dApp\n4. URI de Edge Login para iniciar sesión en otro dispositivo\n\nEdge detectará automáticamente el formato de la URI y te permitirá seleccionar una billetera adecuada",
"enter_any_input_hint": "Ingresa cualquiera de los anteriores",
diff --git a/src/locales/strings/fr.json b/src/locales/strings/fr.json
--- a/src/locales/strings/fr.json
+++ b/src/locales/strings/fr.json
@@ -1086,8 +1086,7 @@
"personalize_wallet_title": "Personalize Your Wallet",
"get_started_button": "Get Started",
"not_now_button": "Not Now",
- "scan_address_modal_title": "Enter Recipient Public Address",
- "scan_address_modal_title_1s": "Enter Recipient %1$s or Public Address",
+ "scan_address_modal_title": "Enter Recipient FIO, ENS, or Public Address",
"enter_any_title": "Enter any of the following:",
"enter_any_body": "1. Public address to send money to\n2. Private key to sweep\n3. Wallet Connect URI to connect to a dApp\n4. Edge Login URI to login to another device\n\nEdge will auto-detect the URI format and allow you to select an appropriate wallet",
"enter_any_input_hint": "Enter any of the above",
diff --git a/src/locales/strings/it.json b/src/locales/strings/it.json
--- a/src/locales/strings/it.json
+++ b/src/locales/strings/it.json
@@ -1086,8 +1086,7 @@
"personalize_wallet_title": "Personalizza Il Tuo Portafoglio",
"get_started_button": "Inizia",
"not_now_button": "Non ora",
- "scan_address_modal_title": "Enter Recipient Public Address",
- "scan_address_modal_title_1s": "Enter Recipient %1$s or Public Address",
+ "scan_address_modal_title": "Inserisci indirizzo FIO, ENS o indirizzo pubblico del destinatario",
"enter_any_title": "Inserisci uno dei seguenti elementi:",
"enter_any_body": "1. Indirizzo pubblico a cui inviare denaro\n2. Chiave privata per importare i fondi \n3. URI di Wallet Connect per connetterti a una dApp\n4. Edge Login URI per accedere su un altro dispositivo\n\nEdge rileverà automaticamente il formato URI e ti consentirà di selezionare un portafoglio appropriato",
"enter_any_input_hint": "Inserisci uno qualsiasi dei precedenti",
diff --git a/src/locales/strings/ja.json b/src/locales/strings/ja.json
--- a/src/locales/strings/ja.json
+++ b/src/locales/strings/ja.json
@@ -1086,8 +1086,7 @@
"personalize_wallet_title": "ハンドル名を決めてください",
"get_started_button": "始める",
"not_now_button": "後で",
- "scan_address_modal_title": "Enter Recipient Public Address",
- "scan_address_modal_title_1s": "Enter Recipient %1$s or Public Address",
+ "scan_address_modal_title": "受信者のFIO、ENS、または公開アドレスを入力してください",
"enter_any_title": "次のいずれかを入力します:",
"enter_any_body": "1. 送金先の公開アドレス\n2. スイープ用の秘密鍵\n3. dAppに接続するためのWallet Connect URI\n4. 別のデバイスにログインするためのEdge Login URI\n\nEdgeはURIの形式を自動で検出するため、適切なウォレットを選択することができます。",
"enter_any_input_hint": "上記のいずれかを入力してください",
diff --git a/src/locales/strings/kaa.json b/src/locales/strings/kaa.json
--- a/src/locales/strings/kaa.json
+++ b/src/locales/strings/kaa.json
@@ -1086,8 +1086,7 @@
"personalize_wallet_title": "Personalize Your Wallet",
"get_started_button": "Get Started",
"not_now_button": "Not Now",
- "scan_address_modal_title": "Enter Recipient Public Address",
- "scan_address_modal_title_1s": "Enter Recipient %1$s or Public Address",
+ "scan_address_modal_title": "Enter Recipient FIO, ENS, or Public Address",
"enter_any_title": "Enter any of the following:",
"enter_any_body": "1. Public address to send money to\n2. Private key to sweep\n3. Wallet Connect URI to connect to a dApp\n4. Edge Login URI to login to another device\n\nEdge will auto-detect the URI format and allow you to select an appropriate wallet",
"enter_any_input_hint": "Enter any of the above",
diff --git a/src/locales/strings/ko.json b/src/locales/strings/ko.json
--- a/src/locales/strings/ko.json
+++ b/src/locales/strings/ko.json
@@ -1086,8 +1086,7 @@
"personalize_wallet_title": "Personalize Your Wallet",
"get_started_button": "Get Started",
"not_now_button": "Not Now",
- "scan_address_modal_title": "Enter Recipient Public Address",
- "scan_address_modal_title_1s": "Enter Recipient %1$s or Public Address",
+ "scan_address_modal_title": "Enter Recipient FIO, ENS, or Public Address",
"enter_any_title": "Enter any of the following:",
"enter_any_body": "1. Public address to send money to\n2. Private key to sweep\n3. Wallet Connect URI to connect to a dApp\n4. Edge Login URI to login to another device\n\nEdge will auto-detect the URI format and allow you to select an appropriate wallet",
"enter_any_input_hint": "Enter any of the above",
diff --git a/src/locales/strings/pt.json b/src/locales/strings/pt.json
--- a/src/locales/strings/pt.json
+++ b/src/locales/strings/pt.json
@@ -1086,8 +1086,7 @@
"personalize_wallet_title": "Personalize Sua Carteira",
"get_started_button": "Começar",
"not_now_button": "Agora não",
- "scan_address_modal_title": "Enter Recipient Public Address",
- "scan_address_modal_title_1s": "Enter Recipient %1$s or Public Address",
+ "scan_address_modal_title": "Digite o destinatário FIO, ENS ou Endereço Público",
"enter_any_title": "Digite qualquer um dos seguintes:",
"enter_any_body": "1. Public address para enviar dinheiro\n2. Private key para varrer\n3. Wallet Connect URI para se conectar a um dApp\n4. Edge Login URI para fazer login em outro dispositivo\n\nA Edge detectará automaticamente o formato URI e permitirá que você selecione uma carteira apropriada",
"enter_any_input_hint": "Digite qualquer um dos itens acima",
diff --git a/src/locales/strings/ru.json b/src/locales/strings/ru.json
--- a/src/locales/strings/ru.json
+++ b/src/locales/strings/ru.json
@@ -1086,8 +1086,7 @@
"personalize_wallet_title": "Personalize Your Wallet",
"get_started_button": "Get Started",
"not_now_button": "Not Now",
- "scan_address_modal_title": "Enter Recipient Public Address",
- "scan_address_modal_title_1s": "Enter Recipient %1$s or Public Address",
+ "scan_address_modal_title": "Введите FIO, ENS или публичный адрес получателя",
"enter_any_title": "Enter any of the following:",
"enter_any_body": "1. Public address to send money to\n2. Private key to sweep\n3. Wallet Connect URI to connect to a dApp\n4. Edge Login URI to login to another device\n\nEdge will auto-detect the URI format and allow you to select an appropriate wallet",
"enter_any_input_hint": "Enter any of the above",
diff --git a/src/locales/strings/vi.json b/src/locales/strings/vi.json
--- a/src/locales/strings/vi.json
+++ b/src/locales/strings/vi.json
@@ -1086,8 +1086,7 @@
"personalize_wallet_title": "Personalize Your Wallet",
"get_started_button": "Get Started",
"not_now_button": "Not Now",
- "scan_address_modal_title": "Enter Recipient Public Address",
- "scan_address_modal_title_1s": "Enter Recipient %1$s or Public Address",
+ "scan_address_modal_title": "Enter Recipient FIO, ENS, or Public Address",
"enter_any_title": "Enter any of the following:",
"enter_any_body": "1. Public address to send money to\n2. Private key to sweep\n3. Wallet Connect URI to connect to a dApp\n4. Edge Login URI to login to another device\n\nEdge will auto-detect the URI format and allow you to select an appropriate wallet",
"enter_any_input_hint": "Enter any of the above",
diff --git a/src/locales/strings/zh.json b/src/locales/strings/zh.json
--- a/src/locales/strings/zh.json
+++ b/src/locales/strings/zh.json
@@ -1086,8 +1086,7 @@
"personalize_wallet_title": "Personalize Your Wallet",
"get_started_button": "Get Started",
"not_now_button": "Not Now",
- "scan_address_modal_title": "Enter Recipient Public Address",
- "scan_address_modal_title_1s": "Enter Recipient %1$s or Public Address",
+ "scan_address_modal_title": "Enter Recipient FIO, ENS, or Public Address",
"enter_any_title": "Enter any of the following:",
"enter_any_body": "1. Public address to send money to\n2. Private key to sweep\n3. Wallet Connect URI to connect to a dApp\n4. Edge Login URI to login to another device\n\nEdge will auto-detect the URI format and allow you to select an appropriate wallet",
"enter_any_input_hint": "Enter any of the above",You can send follow-ups to the cloud agent here.
[ci skip]
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Non-English locales lose FIO/ENS from address modal title
- Restored locale address modal titles to include FIO and ENS and removed the inaccessible extra key from non-English JSON files.
Or push these changes by commenting:
@cursor push 22dd8cfe7c
Preview (22dd8cfe7c)
diff --git a/src/locales/strings/de.json b/src/locales/strings/de.json
--- a/src/locales/strings/de.json
+++ b/src/locales/strings/de.json
@@ -1086,8 +1086,7 @@
"personalize_wallet_title": "Personalize Your Wallet",
"get_started_button": "Get Started",
"not_now_button": "Not Now",
- "scan_address_modal_title": "Enter Recipient Public Address",
- "scan_address_modal_title_1s": "Enter Recipient %1$s or Public Address",
+ "scan_address_modal_title": "Empfänger FIO, ENS oder öffentliche Adresse eingeben",
"enter_any_title": "Enter any of the following:",
"enter_any_body": "1. Public address to send money to\n2. Private key to sweep\n3. Wallet Connect URI to connect to a dApp\n4. Edge Login URI to login to another device\n\nEdge will auto-detect the URI format and allow you to select an appropriate wallet",
"enter_any_input_hint": "Enter any of the above",
diff --git a/src/locales/strings/es.json b/src/locales/strings/es.json
--- a/src/locales/strings/es.json
+++ b/src/locales/strings/es.json
@@ -1086,8 +1086,7 @@
"personalize_wallet_title": "Personalize Your Wallet",
"get_started_button": "Get Started",
"not_now_button": "Not Now",
- "scan_address_modal_title": "Enter Recipient Public Address",
- "scan_address_modal_title_1s": "Enter Recipient %1$s or Public Address",
+ "scan_address_modal_title": "Introduce el destinatario FIO, ENS, o dirección pública",
"enter_any_title": "Enter any of the following:",
"enter_any_body": "1. Public address to send money to\n2. Private key to sweep\n3. Wallet Connect URI to connect to a dApp\n4. Edge Login URI to login to another device\n\nEdge will auto-detect the URI format and allow you to select an appropriate wallet",
"enter_any_input_hint": "Enter any of the above",
diff --git a/src/locales/strings/esMX.json b/src/locales/strings/esMX.json
--- a/src/locales/strings/esMX.json
+++ b/src/locales/strings/esMX.json
@@ -1086,8 +1086,7 @@
"personalize_wallet_title": "Personaliza tu billetera",
"get_started_button": "Comenzar",
"not_now_button": "Ahora no",
- "scan_address_modal_title": "Enter Recipient Public Address",
- "scan_address_modal_title_1s": "Enter Recipient %1$s or Public Address",
+ "scan_address_modal_title": "Introduce el destinatario FIO, ENS, o dirección pública",
"enter_any_title": "Ingresa cualquiera de los siguientes:",
"enter_any_body": "1. Dirección pública para enviar dinero\n2. Clave privada para barrer fondos\n3. URI de Wallet Connect para conectar con una dApp\n4. URI de Edge Login para iniciar sesión en otro dispositivo\n\nEdge detectará automáticamente el formato de la URI y te permitirá seleccionar una billetera adecuada",
"enter_any_input_hint": "Ingresa cualquiera de los anteriores",
diff --git a/src/locales/strings/fr.json b/src/locales/strings/fr.json
--- a/src/locales/strings/fr.json
+++ b/src/locales/strings/fr.json
@@ -1086,8 +1086,7 @@
"personalize_wallet_title": "Personalize Your Wallet",
"get_started_button": "Get Started",
"not_now_button": "Not Now",
- "scan_address_modal_title": "Enter Recipient Public Address",
- "scan_address_modal_title_1s": "Enter Recipient %1$s or Public Address",
+ "scan_address_modal_title": "Enter Recipient FIO, ENS, or Public Address",
"enter_any_title": "Enter any of the following:",
"enter_any_body": "1. Public address to send money to\n2. Private key to sweep\n3. Wallet Connect URI to connect to a dApp\n4. Edge Login URI to login to another device\n\nEdge will auto-detect the URI format and allow you to select an appropriate wallet",
"enter_any_input_hint": "Enter any of the above",
diff --git a/src/locales/strings/it.json b/src/locales/strings/it.json
--- a/src/locales/strings/it.json
+++ b/src/locales/strings/it.json
@@ -1086,8 +1086,7 @@
"personalize_wallet_title": "Personalizza Il Tuo Portafoglio",
"get_started_button": "Inizia",
"not_now_button": "Non ora",
- "scan_address_modal_title": "Inserisci l'indirizzo pubblico del destinatario",
- "scan_address_modal_title_1s": "Inserisci il destinatario %1$s o l'indirizzo pubblico",
+ "scan_address_modal_title": "Inserisci indirizzo FIO, ENS o indirizzo pubblico del destinatario",
"enter_any_title": "Inserisci uno dei seguenti elementi:",
"enter_any_body": "1. Indirizzo pubblico a cui inviare denaro\n2. Chiave privata per importare i fondi \n3. URI di Wallet Connect per connetterti a una dApp\n4. Edge Login URI per accedere su un altro dispositivo\n\nEdge rileverà automaticamente il formato URI e ti consentirà di selezionare un portafoglio appropriato",
"enter_any_input_hint": "Inserisci uno qualsiasi dei precedenti",
diff --git a/src/locales/strings/ja.json b/src/locales/strings/ja.json
--- a/src/locales/strings/ja.json
+++ b/src/locales/strings/ja.json
@@ -1086,8 +1086,7 @@
"personalize_wallet_title": "ハンドル名を決めてください",
"get_started_button": "始める",
"not_now_button": "後で",
- "scan_address_modal_title": "Enter Recipient Public Address",
- "scan_address_modal_title_1s": "Enter Recipient %1$s or Public Address",
+ "scan_address_modal_title": "受信者のFIO、ENS、または公開アドレスを入力してください",
"enter_any_title": "次のいずれかを入力します:",
"enter_any_body": "1. 送金先の公開アドレス\n2. スイープ用の秘密鍵\n3. dAppに接続するためのWallet Connect URI\n4. 別のデバイスにログインするためのEdge Login URI\n\nEdgeはURIの形式を自動で検出するため、適切なウォレットを選択することができます。",
"enter_any_input_hint": "上記のいずれかを入力してください",
diff --git a/src/locales/strings/kaa.json b/src/locales/strings/kaa.json
--- a/src/locales/strings/kaa.json
+++ b/src/locales/strings/kaa.json
@@ -1086,8 +1086,7 @@
"personalize_wallet_title": "Personalize Your Wallet",
"get_started_button": "Get Started",
"not_now_button": "Not Now",
- "scan_address_modal_title": "Enter Recipient Public Address",
- "scan_address_modal_title_1s": "Enter Recipient %1$s or Public Address",
+ "scan_address_modal_title": "Enter Recipient FIO, ENS, or Public Address",
"enter_any_title": "Enter any of the following:",
"enter_any_body": "1. Public address to send money to\n2. Private key to sweep\n3. Wallet Connect URI to connect to a dApp\n4. Edge Login URI to login to another device\n\nEdge will auto-detect the URI format and allow you to select an appropriate wallet",
"enter_any_input_hint": "Enter any of the above",
diff --git a/src/locales/strings/ko.json b/src/locales/strings/ko.json
--- a/src/locales/strings/ko.json
+++ b/src/locales/strings/ko.json
@@ -1086,8 +1086,7 @@
"personalize_wallet_title": "Personalize Your Wallet",
"get_started_button": "Get Started",
"not_now_button": "Not Now",
- "scan_address_modal_title": "Enter Recipient Public Address",
- "scan_address_modal_title_1s": "Enter Recipient %1$s or Public Address",
+ "scan_address_modal_title": "Enter Recipient FIO, ENS, or Public Address",
"enter_any_title": "Enter any of the following:",
"enter_any_body": "1. Public address to send money to\n2. Private key to sweep\n3. Wallet Connect URI to connect to a dApp\n4. Edge Login URI to login to another device\n\nEdge will auto-detect the URI format and allow you to select an appropriate wallet",
"enter_any_input_hint": "Enter any of the above",
diff --git a/src/locales/strings/pt.json b/src/locales/strings/pt.json
--- a/src/locales/strings/pt.json
+++ b/src/locales/strings/pt.json
@@ -1086,8 +1086,7 @@
"personalize_wallet_title": "Personalize Sua Carteira",
"get_started_button": "Começar",
"not_now_button": "Agora não",
- "scan_address_modal_title": "Enter Recipient Public Address",
- "scan_address_modal_title_1s": "Enter Recipient %1$s or Public Address",
+ "scan_address_modal_title": "Digite o destinatário FIO, ENS ou Endereço Público",
"enter_any_title": "Digite qualquer um dos seguintes:",
"enter_any_body": "1. Public address para enviar dinheiro\n2. Private key para varrer\n3. Wallet Connect URI para se conectar a um dApp\n4. Edge Login URI para fazer login em outro dispositivo\n\nA Edge detectará automaticamente o formato URI e permitirá que você selecione uma carteira apropriada",
"enter_any_input_hint": "Digite qualquer um dos itens acima",
diff --git a/src/locales/strings/ru.json b/src/locales/strings/ru.json
--- a/src/locales/strings/ru.json
+++ b/src/locales/strings/ru.json
@@ -1086,8 +1086,7 @@
"personalize_wallet_title": "Personalize Your Wallet",
"get_started_button": "Get Started",
"not_now_button": "Not Now",
- "scan_address_modal_title": "Enter Recipient Public Address",
- "scan_address_modal_title_1s": "Enter Recipient %1$s or Public Address",
+ "scan_address_modal_title": "Введите FIO, ENS или публичный адрес получателя",
"enter_any_title": "Enter any of the following:",
"enter_any_body": "1. Public address to send money to\n2. Private key to sweep\n3. Wallet Connect URI to connect to a dApp\n4. Edge Login URI to login to another device\n\nEdge will auto-detect the URI format and allow you to select an appropriate wallet",
"enter_any_input_hint": "Enter any of the above",
diff --git a/src/locales/strings/vi.json b/src/locales/strings/vi.json
--- a/src/locales/strings/vi.json
+++ b/src/locales/strings/vi.json
@@ -1086,8 +1086,7 @@
"personalize_wallet_title": "Personalize Your Wallet",
"get_started_button": "Get Started",
"not_now_button": "Not Now",
- "scan_address_modal_title": "Enter Recipient Public Address",
- "scan_address_modal_title_1s": "Enter Recipient %1$s or Public Address",
+ "scan_address_modal_title": "Enter Recipient FIO, ENS, or Public Address",
"enter_any_title": "Enter any of the following:",
"enter_any_body": "1. Public address to send money to\n2. Private key to sweep\n3. Wallet Connect URI to connect to a dApp\n4. Edge Login URI to login to another device\n\nEdge will auto-detect the URI format and allow you to select an appropriate wallet",
"enter_any_input_hint": "Enter any of the above",
diff --git a/src/locales/strings/zh.json b/src/locales/strings/zh.json
--- a/src/locales/strings/zh.json
+++ b/src/locales/strings/zh.json
@@ -1086,8 +1086,7 @@
"personalize_wallet_title": "Personalize Your Wallet",
"get_started_button": "Get Started",
"not_now_button": "Not Now",
- "scan_address_modal_title": "Enter Recipient Public Address",
- "scan_address_modal_title_1s": "Enter Recipient %1$s or Public Address",
+ "scan_address_modal_title": "Enter Recipient FIO, ENS, or Public Address",
"enter_any_title": "Enter any of the following:",
"enter_any_body": "1. Public address to send money to\n2. Private key to sweep\n3. Wallet Connect URI to connect to a dApp\n4. Edge Login URI to login to another device\n\nEdge will auto-detect the URI format and allow you to select an appropriate wallet",
"enter_any_input_hint": "Enter any of the above",You can send follow-ups to the cloud agent here.
Reviewed by Cursor Bugbot for commit d2e9603. Configure here.
| "not_now_button": "Not Now", | ||
| "scan_address_modal_title": "Empfänger FIO, ENS oder öffentliche Adresse eingeben", | ||
| "scan_address_modal_title": "Enter Recipient Public Address", | ||
| "scan_address_modal_title_1s": "Enter Recipient %1$s or Public Address", |
There was a problem hiding this comment.
Non-English locales lose FIO/ENS from address modal title
Medium Severity
The scan_address_modal_title in non-English locale files was changed to "Enter Recipient Public Address", dropping FIO and ENS mentions. The English source (en_US.ts) still says "Enter Recipient FIO, ENS, or Public Address". Because mergeStrings overlays locale strings onto the English base, non-English users will see the locale version without FIO/ENS, while English users still see them. Additionally, the new scan_address_modal_title_1s key exists in these translation files but not in en_US.ts or enUS.json, making it inaccessible through the type system. Several locales (de, es, esMX, ja, pt, ru) also lost their proper translations, replaced with untranslated English.
Additional Locations (2)
Triggered by learned rule: Adding a name service must not remove existing services from UI strings
Reviewed by Cursor Bugbot for commit d2e9603. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Only updates localized string resources for the address scan modal; no logic changes. Risk is limited to UI text regressions/missing translation keys at runtime.
Overview
Updates multiple locale JSON files to change
scan_address_modal_titlecopy to "Enter Recipient Public Address" and introduces a new parameterized variantscan_address_modal_title_1s("Enter Recipient %1$s or Public Address"). This aligns the address-entry modal title text across languages (some previously mentioned FIO/ENS) and enables a dynamic recipient-type label.Reviewed by Cursor Bugbot for commit c1261d2. Bugbot is set up for automated code reviews on this repo. Configure here.