Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/locales/strings/de.json
Original file line number Diff line number Diff line change
Expand Up @@ -1086,7 +1086,8 @@
"personalize_wallet_title": "Personalize Your Wallet",
"get_started_button": "Get Started",
"not_now_button": "Not Now",
"scan_address_modal_title": "Empfänger FIO, ENS oder öffentliche Adresse eingeben",
"scan_address_modal_title": "Enter Recipient Public Address",
Comment thread
cursor[bot] marked this conversation as resolved.
"scan_address_modal_title_1s": "Enter Recipient %1$s or Public Address",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-English locales lose FIO/ENS from address modal title

Medium Severity

The scan_address_modal_title in non-English locale files was changed to "Enter Recipient Public Address", dropping FIO and ENS mentions. The English source (en_US.ts) still says "Enter Recipient FIO, ENS, or Public Address". Because mergeStrings overlays locale strings onto the English base, non-English users will see the locale version without FIO/ENS, while English users still see them. Additionally, the new scan_address_modal_title_1s key exists in these translation files but not in en_US.ts or enUS.json, making it inaccessible through the type system. Several locales (de, es, esMX, ja, pt, ru) also lost their proper translations, replaced with untranslated English.

Additional Locations (2)
Fix in Cursor Fix in Web

Triggered by learned rule: Adding a name service must not remove existing services from UI strings

Reviewed by Cursor Bugbot for commit d2e9603. Configure here.

"enter_any_title": "Enter any of the following:",
"enter_any_body": "1. Public address to send money to\n2. Private key to sweep\n3. Wallet Connect URI to connect to a dApp\n4. Edge Login URI to login to another device\n\nEdge will auto-detect the URI format and allow you to select an appropriate wallet",
"enter_any_input_hint": "Enter any of the above",
Expand Down
3 changes: 2 additions & 1 deletion src/locales/strings/es.json
Original file line number Diff line number Diff line change
Expand Up @@ -1086,7 +1086,8 @@
"personalize_wallet_title": "Personalize Your Wallet",
"get_started_button": "Get Started",
"not_now_button": "Not Now",
"scan_address_modal_title": "Introduce el destinatario FIO, ENS, o dirección pública",
"scan_address_modal_title": "Enter Recipient Public Address",
"scan_address_modal_title_1s": "Enter Recipient %1$s or Public Address",
"enter_any_title": "Enter any of the following:",
"enter_any_body": "1. Public address to send money to\n2. Private key to sweep\n3. Wallet Connect URI to connect to a dApp\n4. Edge Login URI to login to another device\n\nEdge will auto-detect the URI format and allow you to select an appropriate wallet",
"enter_any_input_hint": "Enter any of the above",
Expand Down
3 changes: 2 additions & 1 deletion src/locales/strings/esMX.json
Original file line number Diff line number Diff line change
Expand Up @@ -1086,7 +1086,8 @@
"personalize_wallet_title": "Personaliza tu billetera",
"get_started_button": "Comenzar",
"not_now_button": "Ahora no",
"scan_address_modal_title": "Introduce el destinatario FIO, ENS, o dirección pública",
"scan_address_modal_title": "Enter Recipient Public Address",
"scan_address_modal_title_1s": "Enter Recipient %1$s or Public Address",
"enter_any_title": "Ingresa cualquiera de los siguientes:",
"enter_any_body": "1. Dirección pública para enviar dinero\n2. Clave privada para barrer fondos\n3. URI de Wallet Connect para conectar con una dApp\n4. URI de Edge Login para iniciar sesión en otro dispositivo\n\nEdge detectará automáticamente el formato de la URI y te permitirá seleccionar una billetera adecuada",
"enter_any_input_hint": "Ingresa cualquiera de los anteriores",
Expand Down
3 changes: 2 additions & 1 deletion src/locales/strings/fr.json
Original file line number Diff line number Diff line change
Expand Up @@ -1086,7 +1086,8 @@
"personalize_wallet_title": "Personalize Your Wallet",
"get_started_button": "Get Started",
"not_now_button": "Not Now",
"scan_address_modal_title": "Enter Recipient FIO, ENS, or Public Address",
"scan_address_modal_title": "Enter Recipient Public Address",
"scan_address_modal_title_1s": "Enter Recipient %1$s or Public Address",
"enter_any_title": "Enter any of the following:",
"enter_any_body": "1. Public address to send money to\n2. Private key to sweep\n3. Wallet Connect URI to connect to a dApp\n4. Edge Login URI to login to another device\n\nEdge will auto-detect the URI format and allow you to select an appropriate wallet",
"enter_any_input_hint": "Enter any of the above",
Expand Down
3 changes: 2 additions & 1 deletion src/locales/strings/it.json
Original file line number Diff line number Diff line change
Expand Up @@ -1086,7 +1086,8 @@
"personalize_wallet_title": "Personalizza Il Tuo Portafoglio",
"get_started_button": "Inizia",
"not_now_button": "Non ora",
"scan_address_modal_title": "Inserisci indirizzo FIO, ENS o indirizzo pubblico del destinatario",
"scan_address_modal_title": "Inserisci l'indirizzo pubblico del destinatario",
"scan_address_modal_title_1s": "Inserisci il destinatario %1$s o l'indirizzo pubblico",
"enter_any_title": "Inserisci uno dei seguenti elementi:",
"enter_any_body": "1. Indirizzo pubblico a cui inviare denaro\n2. Chiave privata per importare i fondi \n3. URI di Wallet Connect per connetterti a una dApp\n4. Edge Login URI per accedere su un altro dispositivo\n\nEdge rileverà automaticamente il formato URI e ti consentirà di selezionare un portafoglio appropriato",
"enter_any_input_hint": "Inserisci uno qualsiasi dei precedenti",
Expand Down
3 changes: 2 additions & 1 deletion src/locales/strings/ja.json
Original file line number Diff line number Diff line change
Expand Up @@ -1086,7 +1086,8 @@
"personalize_wallet_title": "ハンドル名を決めてください",
"get_started_button": "始める",
"not_now_button": "後で",
"scan_address_modal_title": "受信者のFIO、ENS、または公開アドレスを入力してください",
"scan_address_modal_title": "Enter Recipient Public Address",
"scan_address_modal_title_1s": "Enter Recipient %1$s or Public Address",
"enter_any_title": "次のいずれかを入力します:",
"enter_any_body": "1. 送金先の公開アドレス\n2. スイープ用の秘密鍵\n3. dAppに接続するためのWallet Connect URI\n4. 別のデバイスにログインするためのEdge Login URI\n\nEdgeはURIの形式を自動で検出するため、適切なウォレットを選択することができます。",
"enter_any_input_hint": "上記のいずれかを入力してください",
Expand Down
3 changes: 2 additions & 1 deletion src/locales/strings/kaa.json
Original file line number Diff line number Diff line change
Expand Up @@ -1086,7 +1086,8 @@
"personalize_wallet_title": "Personalize Your Wallet",
"get_started_button": "Get Started",
"not_now_button": "Not Now",
"scan_address_modal_title": "Enter Recipient FIO, ENS, or Public Address",
"scan_address_modal_title": "Enter Recipient Public Address",
"scan_address_modal_title_1s": "Enter Recipient %1$s or Public Address",
"enter_any_title": "Enter any of the following:",
"enter_any_body": "1. Public address to send money to\n2. Private key to sweep\n3. Wallet Connect URI to connect to a dApp\n4. Edge Login URI to login to another device\n\nEdge will auto-detect the URI format and allow you to select an appropriate wallet",
"enter_any_input_hint": "Enter any of the above",
Expand Down
3 changes: 2 additions & 1 deletion src/locales/strings/ko.json
Original file line number Diff line number Diff line change
Expand Up @@ -1086,7 +1086,8 @@
"personalize_wallet_title": "Personalize Your Wallet",
"get_started_button": "Get Started",
"not_now_button": "Not Now",
"scan_address_modal_title": "Enter Recipient FIO, ENS, or Public Address",
"scan_address_modal_title": "Enter Recipient Public Address",
"scan_address_modal_title_1s": "Enter Recipient %1$s or Public Address",
"enter_any_title": "Enter any of the following:",
"enter_any_body": "1. Public address to send money to\n2. Private key to sweep\n3. Wallet Connect URI to connect to a dApp\n4. Edge Login URI to login to another device\n\nEdge will auto-detect the URI format and allow you to select an appropriate wallet",
"enter_any_input_hint": "Enter any of the above",
Expand Down
3 changes: 2 additions & 1 deletion src/locales/strings/pt.json
Original file line number Diff line number Diff line change
Expand Up @@ -1086,7 +1086,8 @@
"personalize_wallet_title": "Personalize Sua Carteira",
"get_started_button": "Começar",
"not_now_button": "Agora não",
"scan_address_modal_title": "Digite o destinatário FIO, ENS ou Endereço Público",
"scan_address_modal_title": "Enter Recipient Public Address",
"scan_address_modal_title_1s": "Enter Recipient %1$s or Public Address",
"enter_any_title": "Digite qualquer um dos seguintes:",
"enter_any_body": "1. Public address para enviar dinheiro\n2. Private key para varrer\n3. Wallet Connect URI para se conectar a um dApp\n4. Edge Login URI para fazer login em outro dispositivo\n\nA Edge detectará automaticamente o formato URI e permitirá que você selecione uma carteira apropriada",
"enter_any_input_hint": "Digite qualquer um dos itens acima",
Expand Down
3 changes: 2 additions & 1 deletion src/locales/strings/ru.json
Original file line number Diff line number Diff line change
Expand Up @@ -1086,7 +1086,8 @@
"personalize_wallet_title": "Personalize Your Wallet",
"get_started_button": "Get Started",
"not_now_button": "Not Now",
"scan_address_modal_title": "Введите FIO, ENS или публичный адрес получателя",
"scan_address_modal_title": "Enter Recipient Public Address",
"scan_address_modal_title_1s": "Enter Recipient %1$s or Public Address",
"enter_any_title": "Enter any of the following:",
"enter_any_body": "1. Public address to send money to\n2. Private key to sweep\n3. Wallet Connect URI to connect to a dApp\n4. Edge Login URI to login to another device\n\nEdge will auto-detect the URI format and allow you to select an appropriate wallet",
"enter_any_input_hint": "Enter any of the above",
Expand Down
3 changes: 2 additions & 1 deletion src/locales/strings/vi.json
Original file line number Diff line number Diff line change
Expand Up @@ -1086,7 +1086,8 @@
"personalize_wallet_title": "Personalize Your Wallet",
"get_started_button": "Get Started",
"not_now_button": "Not Now",
"scan_address_modal_title": "Enter Recipient FIO, ENS, or Public Address",
"scan_address_modal_title": "Enter Recipient Public Address",
"scan_address_modal_title_1s": "Enter Recipient %1$s or Public Address",
"enter_any_title": "Enter any of the following:",
"enter_any_body": "1. Public address to send money to\n2. Private key to sweep\n3. Wallet Connect URI to connect to a dApp\n4. Edge Login URI to login to another device\n\nEdge will auto-detect the URI format and allow you to select an appropriate wallet",
"enter_any_input_hint": "Enter any of the above",
Expand Down
3 changes: 2 additions & 1 deletion src/locales/strings/zh.json
Original file line number Diff line number Diff line change
Expand Up @@ -1086,7 +1086,8 @@
"personalize_wallet_title": "Personalize Your Wallet",
"get_started_button": "Get Started",
"not_now_button": "Not Now",
"scan_address_modal_title": "Enter Recipient FIO, ENS, or Public Address",
"scan_address_modal_title": "Enter Recipient Public Address",
"scan_address_modal_title_1s": "Enter Recipient %1$s or Public Address",
"enter_any_title": "Enter any of the following:",
"enter_any_body": "1. Public address to send money to\n2. Private key to sweep\n3. Wallet Connect URI to connect to a dApp\n4. Edge Login URI to login to another device\n\nEdge will auto-detect the URI format and allow you to select an appropriate wallet",
"enter_any_input_hint": "Enter any of the above",
Expand Down
Loading