Skip to content

Conversation

@Milotrince
Copy link
Contributor

Description

nice-to-have feature, allows users to integrate interactive viewer plugins.

Related Issue

N/A

Motivation and Context

Enables directly interfacing with pyviewer mouse/keyboard controls

How Has This Been / Can This Be Tested?

todo

Screenshots (if appropriate):

Screen.Recording.2025-11-17.at.18.03.51.mov

Checklist:

  • I read the CONTRIBUTING document.
  • I followed the Submitting Code Changes section of CONTRIBUTING document.
  • I tagged the title correctly (including BUG FIX/FEATURE/MISC/BREAKING)
  • I updated the documentation accordingly or no change is needed.
  • I tested my changes and added instructions on how to test it for reviewers.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@duburcqa
Copy link
Collaborator

This feature looks very convenient!

@Milotrince
Copy link
Contributor Author

  • Should we keep under genesis/ext/pyrender/interaction/plugins/ or genesis/vis/plugins ?
  • Do we want to use Vec3, Quat, Color, Ray, etc. classes in the codebase?
  • now that pyrender viewer mouse/keyboard interaction is exposed, we can get rid of pynput in examples

@duburcqa
Copy link
Collaborator

Should we keep under genesis/ext/pyrender/interaction/plugins/ or genesis/vis/plugins ?

Do you consider this as a "universal" plugin or something pyrender-specific? This would give you the answer :)

Do we want to use Vec3, Quat, Color, Ray, etc. classes in the codebase?

I'm not a fan of these objects. Overly complicated and not very pythonic in my view.

now that pyrender viewer mouse/keyboard interaction is exposed, we can get rid of pynput in examples

That would be great! But we need a way to expose this in a clean way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants