-
Notifications
You must be signed in to change notification settings - Fork 56
CI: runs tests on 4.x versions of Blender, drops tests on unsupported versions #330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
8258007 to
604a5ae
Compare
|
Before we can drop unsupported versions and add the supported versions we need to decide what versions we want to support (and then we should note it down as our policy). The initial informal policy for the add-on was to only support the latest Blender release, but I have always thought that was too inflexible and it relaxed as time went by, though no formal policy was ever adopted. Some possible policies we could adopt (in no particular order).
For the options that contain team decided versions, what team should decide is another question. I would say that probably the art team should decide, but arguments can be made for the programming and governance teams too. My preference would probably be for option 2 or option 4. Fun fact, I still predominantly use Blender 3.6 because the EEVEE shaders compile exceptionally quicker than future LTS releases. I just took some rough numbers and this is how long it takes for the EEVEE shaders to compile on the same, fairly simple, scene for the different versions: 4 seconds for Blender 3.6.14 LTS So even though it would normally make sense, I'm not sure whether I really want to drop support for Blender 3.6 yet. Another thing to think about is what we do when we drop support for a version, i.e. do we just not test on it anymore, or do we remove any version specific support for it that was introduced? @jua360 @hobbs-Hobbler @Spiderguy-F @GottfriedHofmann @aelainelong @theanine3D Feel free to weigh in on this as well (and feel free to tag anyone else who you think would be appropriate). |
|
I think we should support (test on) all the currently supported versions of Blender (including LTS versions). I don't think we should remove code unless it makes non-trivial difficulties. So, the plugin should continue to work with old versions of Blender, but we don't put any effort into doing so. If a new version of the plugin loses compatibility with an old version of Blender, users can still use an old version of the plugin. Of course, we could make a special exception for a particular unsupported version of Blender, if the Art and Programming teams agreed. |
|
I have successfully been maintaining compatibility with as far back as Blender 3.0 in my own Blender addons. So it's doable - but it does require some mindfulness and extra code to check for versions. Since we have a very limited amount of people, I would say being practical has to be the winning option. I would go with option 1: We don't need to outright block older versions - they should still be able to install and try running the addon, and much of the addon will likely still work. But we won't provide support for anything broken if they're running an unsupported version. |
…ported versions Why: We need to test against all supported versions, but not against unsupported versions
|
It looks like @Exairnous 's option 2
...with the possibility of adding specific releases, would satisfy everyone. That makes the current list: |
|
Thank you to everyone so far who has provided opinions on the policy for what Blender versions to support. I want to mull things over a bit before responding further, but in the mean time, I wanted to note a few things I found out about the tests failing in Blender 4.5 and 5.0. It seems that our support for HDR images may be what's causing the issue. The Since the embedded format is text based, we could potentially switch to using the embedded format for the tests, but this has the downside of sightly larger file sizes and potentially just sweeps the problem under the rug/out of sight. I'll try to keep this PR updated with anything additional I find out about this issue. |


What?
CI: runs tests on 4.x versions of Blender, drops tests on unsupported versions
Why?
We need to test against all supported versions, but not against unsupported versions
How to test
Documentation of functionality
The docs don't state what versions of Blender this works with, so no changes are necessary
Limitations
Doesn't test 5.0, which is on the verge of being released