Skip to content

Conversation

@rakdutta
Copy link
Collaborator

@rakdutta rakdutta commented Nov 14, 2025

closed issue #1318 and,#1452

This pull request introduces several enhancements and fixes across the admin endpoints and service layers, primarily focused on improving gateway filtering, public visibility logic, and associated item handling. The core improvements include adding gateway ID filtering to admin UI endpoints, ensuring public gateways are always visible regardless of team selection, and extending server service logic to support gateways as associated items.

Admin Endpoint Improvements

  • Added a new endpoint admin_list_gateway_ids to provide a list of all gateway IDs for admin UI "Select All" functionality.
  • Introduced gateway_id filtering (comma-separated IDs) to the tools, prompts, and resources admin partial HTML endpoints, including query parameter handling, filtering logic in SQL queries, and propagation of the filter to response payloads. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16]

Gateway Visibility and Filtering

  • Improved logic for matching items to teams, so that items explicitly marked as public are always visible, regardless of the selected team.
  • Updated gateway service logic to always include public gateways (with no team_id) in results, ensuring they are visible even when filtering by team.

Associated Items Handling

  • Extended the _assemble_associated_items method in server_service.py to support gateways as an associated item type, updating the signature, return value, and documentation/examples accordingly. [1] [2]

Gateway Update Logic

  • Commented out logic that only triggered re-fetching of tools/resources/prompts on URL change, suggesting that updates should occur for other gateway changes (e.g., authentication, visibility) as well. [1] [2]

Minor Code Quality Improvements

  • Cleaned up redundant lines and improved clarity in the tool update/create logic. [1] [2]

Let me know if you want a deeper dive into any of these changes or how they affect the admin UI or service layer!

@rakdutta rakdutta force-pushed the feature_1318_filter branch from 2951ab3 to 23b3c87 Compare November 17, 2025 11:47
@rakdutta rakdutta marked this pull request as ready for review November 17, 2025 11:56
@rakdutta rakdutta force-pushed the feature_1318_filter branch from 23b3c87 to fb3393f Compare November 17, 2025 13:08
@MohanLaksh MohanLaksh assigned MohanLaksh and unassigned MohanLaksh Nov 18, 2025
Copy link
Collaborator

@MohanLaksh MohanLaksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Summary:

WHAT WORKS WELL:

Selecting a MCP Server (gateway) will filter and list only the tools, resources and prompts associated with that particular gateway.

WHAT NEEDS A FIX:

  1. Selecting REST payload (tools/resources/prompts) is not possible if one of the gateway is selected in filter.
  2. Reselecting a different gateway will deselect all the earlier selected payload of the prior gateway (tools/resources/prompts).

NEXT STEPS:

  1. Adding a checkbox Include REST to show REST payload during selection.
  2. Maintain the earlier selections when the user is filtering for a different gateway.

QUESTION:

Should it be taken up in a new PR?

Copy link
Collaborator

@madhav165 madhav165 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rakdutta , looks like selecting an MCP server is visually updating the tools, prompts and resources in DOM, but 'Select All' is not using this filtered list. Please fix this so we can merge this PR.

Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
@madhav165
Copy link
Collaborator

Merging PR since the following items are also fixed and tested.

  1. REST tools can be selected through a new MCP server called REST
  2. Select All for tools/prompts/resources fixed after filtering for MCP Server.

@madhav165 madhav165 merged commit e83d101 into main Nov 19, 2025
45 checks passed
@madhav165 madhav165 deleted the feature_1318_filter branch November 19, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants