-
Notifications
You must be signed in to change notification settings - Fork 413
Add Gateway-Based Filtering for Tools, Prompts, and Resources in Admin UI #1445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2951ab3 to
23b3c87
Compare
23b3c87 to
fb3393f
Compare
MohanLaksh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test Summary:
WHAT WORKS WELL:
Selecting a MCP Server (gateway) will filter and list only the tools, resources and prompts associated with that particular gateway.
WHAT NEEDS A FIX:
- Selecting REST payload (tools/resources/prompts) is not possible if one of the gateway is selected in filter.
- Reselecting a different gateway will deselect all the earlier selected payload of the prior gateway (tools/resources/prompts).
NEXT STEPS:
- Adding a checkbox
Include RESTto show REST payload during selection. - Maintain the earlier selections when the user is filtering for a different gateway.
QUESTION:
Should it be taken up in a new PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rakdutta , looks like selecting an MCP server is visually updating the tools, prompts and resources in DOM, but 'Select All' is not using this filtered list. Please fix this so we can merge this PR.
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
Signed-off-by: rakdutta <[email protected]>
e7d2615 to
b3d745d
Compare
|
Merging PR since the following items are also fixed and tested.
|
closed issue #1318 and,#1452
This pull request introduces several enhancements and fixes across the admin endpoints and service layers, primarily focused on improving gateway filtering, public visibility logic, and associated item handling. The core improvements include adding gateway ID filtering to admin UI endpoints, ensuring public gateways are always visible regardless of team selection, and extending server service logic to support gateways as associated items.
Admin Endpoint Improvements
admin_list_gateway_idsto provide a list of all gateway IDs for admin UI "Select All" functionality.gateway_idfiltering (comma-separated IDs) to the tools, prompts, and resources admin partial HTML endpoints, including query parameter handling, filtering logic in SQL queries, and propagation of the filter to response payloads. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16]Gateway Visibility and Filtering
Associated Items Handling
_assemble_associated_itemsmethod inserver_service.pyto support gateways as an associated item type, updating the signature, return value, and documentation/examples accordingly. [1] [2]Gateway Update Logic
Minor Code Quality Improvements
Let me know if you want a deeper dive into any of these changes or how they affect the admin UI or service layer!